Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventsSDK: Remove Partial Payload #123

Merged
merged 10 commits into from
Jan 26, 2024
Merged

EventsSDK: Remove Partial Payload #123

merged 10 commits into from
Jan 26, 2024

Conversation

ejaffee01
Copy link
Contributor

@ejaffee01 ejaffee01 commented Jan 24, 2024

Remove PartialPayload in favor of making all EventPayload properties optional.
This required refactoring merge.ts.

J=FUS-6203
R=abenno, mtian
TEST=auto

Run automated workflows (which required updating the path for the run_tests yml) and added a test to merge.test.ts that merges two payloads without an action property.

src/merge.ts Outdated Show resolved Hide resolved
@ejaffee01 ejaffee01 self-assigned this Jan 25, 2024
Copy link
Collaborator

@mtian725 mtian725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejaffee01 ejaffee01 requested a review from mtian725 January 26, 2024 17:42
@ejaffee01 ejaffee01 merged commit 98a8795 into main Jan 26, 2024
12 checks passed
@ejaffee01 ejaffee01 deleted the makeOpt branch January 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants