Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventsSDK: Add missing properties to EventPayload & make alphabetical #117

Merged
merged 11 commits into from
Nov 14, 2023
Merged

EventsSDK: Add missing properties to EventPayload & make alphabetical #117

merged 11 commits into from
Nov 14, 2023

Conversation

ejaffee01
Copy link
Contributor

@ejaffee01 ejaffee01 commented Oct 25, 2023 •
edited
Loading

Added missing properties to event payload:

  • value
  • location
    • Required adding Coordinates type to represent that location can be an object containing latitude or longitude, or be a
      country string.
  • nonce
  • searchTerm

In addition rearranged the file to make props in alphabetical order.

Testing:

  • Ran unit and playwright tests and all pass
  • Looked at official events api schema side by side with this EventPayload and made sure no properties were missing.

@ejaffee01 ejaffee01 self-assigned this Oct 25, 2023
@ejaffee01 ejaffee01 requested a review from AjayBenno October 25, 2023 20:59
@ejaffee01 ejaffee01 marked this pull request as ready for review October 25, 2023 22:17
@ejaffee01 ejaffee01 changed the title EventsSDK: Add Value property to EventPayload EventsSDK: Add missing properties to EventPayload & make alphabetical Nov 6, 2023
@ejaffee01 ejaffee01 requested a review from mtian725 November 6, 2023 20:04
mtian725
mtian725 reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@mtian725 mtian725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you do for testing?

@ejaffee01 ejaffee01 requested a review from mtian725 November 7, 2023 16:22
mtian725
mtian725 reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@mtian725 mtian725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test files as well. You said you unit and playright tests passed as well, but none of your changes were tested.

@ejaffee01 ejaffee01 requested a review from mtian725 November 7, 2023 20:37
AjayBenno
AjayBenno reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@AjayBenno AjayBenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG comment about nonce

src/EventPayload.ts Outdated Show resolved Hide resolved
@ejaffee01 ejaffee01 requested a review from AjayBenno November 10, 2023 20:49
@ejaffee01 ejaffee01 merged commit f44c8e4 into main Nov 14, 2023
12 checks passed
@ejaffee01 ejaffee01 deleted the dev/value branch November 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtian725 mtian725 mtian725 approved these changes

@AjayBenno AjayBenno Awaiting requested review from AjayBenno

Assignees

@ejaffee01 ejaffee01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejaffee01 @AjayBenno @mtian725