Skip to content

Commit

Permalink
analytics: upgrade github actions (#144)
Browse files Browse the repository at this point in the history
This PR upgrades various github actions from their deprecated v3
versions to v4.
  • Loading branch information
Fondryext authored Feb 4, 2025
1 parent 56a3d7d commit ee444e2
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 15 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,18 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Use Node.js 16
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
cache: "npm"
- run: npm ci
- run: VITE_REGION=${{ inputs.region }} npm run ${{ inputs.build_script }}
- name: Create build-output-${{ inputs.region }} artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-output-${{ inputs.region }}
path: dist/ 
path: dist/ 
8 changes: 4 additions & 4 deletions .github/workflows/deploy_hold.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ jobs:
runs-on: ubuntu-latest
environment: production # sets in github repo with reviewer requirement protection rule
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download build-output-US artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build-output-US
path: dist/
Expand All @@ -50,9 +50,9 @@ jobs:
runs-on: ubuntu-latest
environment: production # sets in github repo with reviewer requirement protection rule
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download build-output-EU artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build-output-EU
path: dist/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ jobs:
image: returntocorp/semgrep
if: (github.actor != 'dependabot[bot]')
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: semgrep ci
8 changes: 4 additions & 4 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Playwright Tests
on: [push, pull_request]

env:
env:
YEXT_API_KEY: ${{ secrets.YEXT_API_KEY }}

jobs:
Expand All @@ -11,8 +11,8 @@ jobs:
container:
image: mcr.microsoft.com/playwright:v1.38.0-jammy
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
- name: Install dependencies
Expand All @@ -23,4 +23,4 @@ jobs:
env:
# Refer to: https://github.com/microsoft/playwright/issues/6500#issuecomment-1577221956
HOME: /root
run: npx playwright test
run: npx playwright test
4 changes: 2 additions & 2 deletions .github/workflows/should_deploy_major_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
outputs:
should_deploy_major_version: ${{ steps.vars.outputs.should_deploy_major_version }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: allow for major version deployment if the next minor version from current tag does not exist
Expand All @@ -36,4 +36,4 @@ jobs:
echo should_deploy_major_version=true >> $GITHUB_OUTPUT
else
echo 'Major version should not be deployed.'
fi
fi

0 comments on commit ee444e2

Please sign in to comment.