Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lesson Statements #62

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Lesson Statements #62

merged 13 commits into from
Nov 21, 2024

Conversation

cliffcaseyyet
Copy link
Member

@cliffcaseyyet cliffcaseyyet commented Nov 14, 2024 •
edited
Loading

  • content page viewed
  • essay assessed
  • lesson ended
  • lesson restarted
  • lesson resumed
  • lesson started
  • question answered (all cmi subtypes)
  • question viewed (all cmi subtypes)

Along the way:

  • Added result to module completion
  • Added a few correctresponse options to cmi subtypes

@cliffcaseyyet cliffcaseyyet changed the title Lesson statements Lesson Statements Nov 19, 2024
@cliffcaseyyet cliffcaseyyet marked this pull request as ready for review November 19, 2024 02:26
milt
milt reviewed Nov 20, 2024
View reviewed changes
tests/mod_lesson/question_answered/choice/statements.json Outdated
}
}
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github is giving me a no newline warning on this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9275d62

milt
milt requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on slack, come up with a type for the "inner" lesson instance and add it to the profile.

@cliffcaseyyet
Copy link
Member Author

As discussed on slack, come up with a type for the "inner" lesson instance and add it to the profile.

2e8bd1b <- that is the code, moodle-sample-statements is already updated. But what is your process for the profile?

@cliffcaseyyet cliffcaseyyet merged commit 5477c26 into master Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt milt approved these changes

@invaliduser invaliduser Awaiting requested review from invaliduser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cliffcaseyyet @milt