Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

badge_viewed #55

Merged
merged 3 commits into from
Nov 22, 2024
Merged

badge_viewed #55

merged 3 commits into from
Nov 22, 2024

Conversation

invaliduser
Copy link

badge_viewed event

milt
milt requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See various

milt
milt requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the differing strategy for lang, this should be consistent. As mentioned elsewhere I think the order is:

  1. badge lang (if set)
  2. course lang (if there is a course)
  3. config source lang

@invaliduser invaliduser requested a review from milt November 21, 2024 17:08
@invaliduser invaliduser merged commit ac0848a into master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt milt approved these changes

@cliffcaseyyet cliffcaseyyet Awaiting requested review from cliffcaseyyet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@invaliduser @milt