Course module completion updated #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milt
commented
Oct 9, 2024
| @@ -47,10 +47,14 @@ function course_module(array $config, \stdClass $course, int $cmid, string $xapi | |||
| $courselang = utils\get_course_lang($course); | |||
| $instancename = property_exists($instance, 'name') ? $instance->name : $module->name; | |||
|
|
|||
| $activitytype = utils\get_module_activity_type($module->name); | |||
There was a problem hiding this comment.
This is basically the biggest change here, xAPI type is decided by a single table, not whatever the caller specifies.
milt
commented
Oct 9, 2024
There was a problem hiding this comment.
This is where the table lives
milt
commented
Oct 9, 2024
cliffcaseyyet
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing/"Uncompleting" course modules. adds tests for both states. Also updates the course module object creator to set its own types.
Note that this touches a lot of stuff because the course module object creation function is (rightly) used all over the plugin.