Skip to content

Commit

Permalink
PHP & Moodle Support Coverage (#75)
Browse files Browse the repository at this point in the history
* add php 8.0 to try and repro bug

* expand matrix

* try latest

* try 8.1 with latest

* try with declared prop

* update lib path

* use package on packagist

* try latest ll version

* correct xml

* nope, ours

* install plugins on 405 whoops

* combinatorial support explosion

* add exclusions of known incompatibilities
  • Loading branch information
milt authored Dec 18, 2024
1 parent 6ef0e99 commit 7de3e58
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 20 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/moodle-plugin-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,18 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ['8.1']
moodle-branch: ['MOODLE_401_STABLE', 'MOODLE_402_STABLE']
php: ['8.1', '8.2', '8.3']
moodle-branch: ['MOODLE_401_STABLE', 'MOODLE_402_STABLE', 'MOODLE_403_STABLE', 'MOODLE_404_STABLE', 'MOODLE_405_STABLE']
database: [pgsql, mariadb]
exclude:
- php: '8.2'
moodle-branch: 'MOODLE_401_STABLE'
- php: '8.3'
moodle-branch: 'MOODLE_401_STABLE'
- php: '8.3'
moodle-branch: 'MOODLE_402_STABLE'
- php: '8.3'
moodle-branch: 'MOODLE_403_STABLE'

steps:
- name: Check out repository code
Expand Down Expand Up @@ -64,8 +73,7 @@ jobs:
cd plugin
composer install
- name: Install additional supported plugins (Moodle 4.0)
if: ${{ matrix.moodle-branch == 'MOODLE_401_STABLE' || matrix.moodle-branch == 'MOODLE_402_STABLE' }}
- name: Install additional supported plugins
run: |
moodle-plugin-ci add-plugin --branch MOODLE_400_STABLE catalyst/moodle-mod_facetoface
moodle-plugin-ci add-plugin --branch MOODLE_400_STABLE moodleworkplace/moodle-tool_certificate
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "xapi-vle/moodle-logstore-xapi",
"license": "GPL v3",
"require-dev": {
"learninglocker/statementfactory": "~0.0"
"yetanalytics/statementfactory": "v0.0.12"
},
"require": {
"ext-json": "*"
Expand Down
31 changes: 19 additions & 12 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions thirdpartylibs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
<licenseversion></licenseversion>
</library>
<library>
<location>vendor/learninglocker/statementfactory/</location>
<location>vendor/yetanalytics/statementfactory/</location>
<name>StatementFactory</name>
<version>v0.0.0</version>
<version>v0.0.12</version>
<license>GPL3</license>
<licenseversion></licenseversion>
</library>
</libraries>
</libraries>

0 comments on commit 7de3e58

Please sign in to comment.