fix get_scaled_score

yetanalytics · Oct 21, 2024 · 1b013c4 · 1b013c4
1 parent 59e3372
commit 1b013c4
Show file tree

Hide file tree

Showing 15 changed files with 15 additions and 19 deletions.
diff --git a/src/transformer/utils/get_scaled_score.php b/src/transformer/utils/get_scaled_score.php
@@ -35,9 +35,5 @@
  * @return int
  */
 function get_scaled_score($rawscore, $minscore, $maxscore) {
-    if ($rawscore >= 0) {
-        return $rawscore / $maxscore;
-    } else {
-        return $rawscore / $minscore;
-    }
+    return (($rawscore - $minscore) / ($maxscore - $minscore) * 2) - 1;
 }
diff --git a/tests/mod_quiz/attempt_submitted/essay/statements.json b/tests/mod_quiz/attempt_submitted/essay/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/essay_null_response/statements.json b/tests/mod_quiz/attempt_submitted/essay_null_response/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/gapselect/statements.json b/tests/mod_quiz/attempt_submitted/gapselect/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/match/statements.json b/tests/mod_quiz/attempt_submitted/match/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/multichoice/statements.json b/tests/mod_quiz/attempt_submitted/multichoice/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/multichoice_withchoices/statements.json b/tests/mod_quiz/attempt_submitted/multichoice_withchoices/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/multichoiceset/statements.json b/tests/mod_quiz/attempt_submitted/multichoiceset/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/multichoiceset_withchoices/statements.json b/tests/mod_quiz/attempt_submitted/multichoiceset_withchoices/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/no_questions/statements.json b/tests/mod_quiz/attempt_submitted/no_questions/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/numerical/statements.json b/tests/mod_quiz/attempt_submitted/numerical/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/randomsamatch/statements.json b/tests/mod_quiz/attempt_submitted/randomsamatch/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/shortanswer/statements.json b/tests/mod_quiz/attempt_submitted/shortanswer/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/truefalse/statements.json b/tests/mod_quiz/attempt_submitted/truefalse/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,

diff --git a/tests/mod_quiz/attempt_submitted/unknown_qtype/statements.json b/tests/mod_quiz/attempt_submitted/unknown_qtype/statements.json
@@ -27,7 +27,7 @@
         "raw": 50,
         "min": 0,
         "max": 100,
-        "scaled": 0.5
+        "scaled": 0.0
       },
       "completion": true,
       "success": true,