Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL-105] Editable API key labels #460

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[SQL-105] Editable API key labels #460

wants to merge 8 commits into from

Conversation

kelvinqian00
Copy link
Collaborator

Implement the backend functionality necessary for editable API key labels. Implement a new label column in lrs_credential, and add label as a parameter to API key objects.

milt
milt approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kelvinqian00 kelvinqian00 requested a review from milt February 10, 2025 19:09
@kelvinqian00
Copy link
Collaborator Author

kelvinqian00 commented Feb 10, 2025 •
edited
Loading

@milt Requested re-review for some bugfixes and arglist changes I added while working on #462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt milt approved these changes

@cliffcaseyyet cliffcaseyyet cliffcaseyyet approved these changes

@invaliduser invaliduser Awaiting requested review from invaliduser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinqian00 @milt @cliffcaseyyet