Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL-264] JWT Renewal + re-route implementation #99

Open
wants to merge 107 commits into
base: main
Choose a base branch
from

Conversation

kelvinqian00
Copy link
Contributor

@kelvinqian00 kelvinqian00 commented Jan 14, 2025

Feature branch for implementing JWT logout and renewal + refactoring the frontend to use re-route.

Main Changes:

  • Implement JWT renewal, storing config vars from BE and renewing using the :login/try-renew effect handler
  • Apply logout to regular login mode via the :logout/logout effect handler (while keeping OIDC and proxy JWT logouts the same)
  • Use re-route to create the following routes:
    • /credentials (same as /)
    • /accounts
    • /accounts/password
    • /browser (statement browser)
    • /data-management (actor delete)
    • /status
    • /reactions
    • /reactions/new
    • /reactions/:id/view
    • /reactions/:id/edit
    • /not-found
  • Dynamically create resource routes (e.g. for images) in ClojureScript (via subscriptions) and HTML (via Selmer templates)

Pull Requests:

@kelvinqian00 kelvinqian00 marked this pull request as ready for review January 14, 2025 20:22
(get-in params [:path-params :id]))
:start (fn [id]
(dispatch [:reaction/set-focus id]))
:stop (fn [_]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very cool.

:update-password [update-password]
:data-management [data-management]
:reactions [reactions])]
(when-some [page @(subscribe [::re-route/route-view])]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer!

Copy link
Member

@cliffcaseyyet cliffcaseyyet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants