-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL-264] JWT Renewal + re-route implementation #99
base: main
Are you sure you want to change the base?
Conversation
[SQL-264] JWT enhancements
[SQL-271] SPA Path Updates to prepare for re-route
[SQL-271] Implement re-route routing
[SQL-272] Refactor Reactions UI with re-route
(get-in params [:path-params :id])) | ||
:start (fn [id] | ||
(dispatch [:reaction/set-focus id])) | ||
:stop (fn [_] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very cool.
:update-password [update-password] | ||
:data-management [data-management] | ||
:reactions [reactions])] | ||
(when-some [page @(subscribe [::re-route/route-view])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much nicer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
Feature branch for implementing JWT logout and renewal + refactoring the frontend to use re-route.
Main Changes:
:login/try-renew
effect handler:logout/logout
effect handler (while keeping OIDC and proxy JWT logouts the same)/credentials
(same as/
)/accounts
/accounts/password
/browser
(statement browser)/data-management
(actor delete)/status
/reactions
/reactions/new
/reactions/:id/view
/reactions/:id/edit
/not-found
Pull Requests: