Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commits #1

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Initial commits #1

merged 8 commits into from
Jan 18, 2024

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented Jan 17, 2024 •
edited
Loading

Initial commits and CI on the build process.

TODO: Test deployment to Clojars once this library is open-sourced.

@kelvinqian00 kelvinqian00 marked this pull request as ready for review January 17, 2024 23:22
@kelvinqian00 kelvinqian00 requested a review from milt January 17, 2024 23:22
milt
milt approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick! Is the idea to make this public once it is working?

@kelvinqian00
Copy link
Collaborator Author

@milt Exactly

@kelvinqian00
Copy link
Collaborator Author

@cliffcaseyyet Just added you as a reviewer to get your approval on open-sourcing this

@kelvinqian00 kelvinqian00 merged commit a03f745 into main Jan 18, 2024
1 check passed
@kelvinqian00 kelvinqian00 deleted the init-commits branch January 18, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milt milt milt approved these changes

@cliffcaseyyet cliffcaseyyet Awaiting requested review from cliffcaseyyet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvinqian00 @milt