Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format files with CPP #973

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Format files with CPP #973

merged 3 commits into from
Jan 15, 2024

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Jan 14, 2024

fourmolu skipped a few files because of CPP, so I've gone through them and:

  • removed the conflicting CPP
  • formatted with fourmolu
  • re-added the CPP sections

@Vlix Vlix requested a review from kazu-yamamoto January 14, 2024 02:50
@Vlix
Copy link
Contributor Author

Vlix commented Jan 14, 2024

Wanted to do this before I continue with the PR #968

@Vlix Vlix mentioned this pull request Jan 14, 2024
Draft
3 tasks
kazu-yamamoto
kazu-yamamoto approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 64e42a2 into yesodweb:master Jan 15, 2024
18 checks passed
@Vlix Vlix deleted the format-files-with-cpp branch January 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @kazu-yamamoto