Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompute chunks for RasterDataset #462

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

precompute chunks for RasterDataset #462

wants to merge 2 commits into from

Conversation

rafaqz
Copy link
Collaborator

@rafaqz rafaqz commented Feb 9, 2025 •
edited
Loading

I think this makes sense to compute up front as its kind of expensive

yeesian
yeesian previously approved these changes Feb 9, 2025
View reviewed changes
Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just have a question about the chunk type since I'm not very familiar with the DiskArrays interface

src/raster/array.jl Show resolved Hide resolved
rafaqz
rafaqz commented Feb 10, 2025
View reviewed changes
src/raster/array.jl Outdated Show resolved Hide resolved
@yeesian @rafaqz
Update src/raster/array.jl
e1b8d10 
Co-authored-by: Rafael Schouten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeesian yeesian yeesian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaqz @yeesian