RFC: Allow to use interactive Datasets in unsafe_gdal functions in utilities.jl #167
Conversation
This would allow to build longer input arrays into vrts.
This allows to use interactive datasets in the unsafe_gdal functions in utilities.jl.
Allow subtypes of AbstractDataset in unsafe_gdal... functions so that we could use these with IDatasets. We use the type of the input as return type, so that we wouldn't accidentally change the approach by using these functions.
The tests are copied from the non-interactive utilities tests and converted to not use the do block notation, but to set the variable and reuse the variable later in the tests.
|
Great, thanks!
This should already be done automatically. Try leaving out |
There was a problem hiding this comment.
This is great, thanks! My comments here are just echoing what @visr has said in #167 (comment), in case having it might help.
If you want corresponding functions that returns the Interactive versions of the corresponding datasets, you can still do so but it has to be a separate implementation. E.g. for gdalwarp, adding the following lines:
function gdalwarp(
datasets::Vector{T},
options = String[];
dest = "/vsimem/tmp"
) where T<:AbstractDataset
options = GDAL.gdalwarpappoptionsnew(options, C_NULL)
usage_error = Ref{Cint}()
result = GDAL.gdalwarp(dest, C_NULL,
length(datasets), [ds.ptr for ds in datasets], options, usage_error)
GDAL.gdalwarpappoptionsfree(options)
return IDataset(result)
endIf an example might help, see e.g. how it's done for fromWKB.
| options = GDAL.gdaltranslateoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdaltranslate(dest, dataset.ptr, options, usage_error) | ||
| GDAL.gdaltranslateoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| options = GDAL.gdalwarpappoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdalwarp(dest, C_NULL, | ||
| length(datasets), [ds.ptr for ds in datasets], options, usage_error) | ||
| GDAL.gdalwarpappoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| options = GDAL.gdalvectortranslateoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdalvectortranslate(dest, C_NULL, length(datasets), | ||
| [ds.ptr for ds in datasets], options, usage_error) | ||
| GDAL.gdalvectortranslateoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| @@ -129,11 +129,11 @@ function unsafe_gdaldem( | |||
| result = GDAL.gdaldemprocessing(dest, dataset.ptr, processing, colorfile, | |||
| options, usage_error) | |||
| GDAL.gdaldemprocessingoptionsfree(options) | |||
| return Dataset(result) | |||
| return T(result) | |||
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| options = GDAL.gdalnearblackoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdalnearblack(dest, C_NULL, dataset.ptr, options, usage_error) | ||
| GDAL.gdalnearblackoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| options = GDAL.gdalgridoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdalgrid(dest, dataset.ptr, options, usage_error) | ||
| GDAL.gdalgridoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| options = GDAL.gdalrasterizeoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdalrasterize(dest, C_NULL, dataset.ptr, options, usage_error) | ||
| GDAL.gdalrasterizeoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
| options = GDAL.gdalbuildvrtoptionsnew(options, C_NULL) | ||
| usage_error = Ref{Cint}() | ||
| result = GDAL.gdalbuildvrt(dest, length(datasets), | ||
| [ds.ptr for ds in datasets], C_NULL, options, usage_error) | ||
| GDAL.gdalbuildvrtoptionsfree(options) | ||
| return Dataset(result) | ||
| return T(result) |
There was a problem hiding this comment.
This should still be Dataset(result) rather than T(result) (see #167 (comment) for context).
This adds the Project.toml and the pluto notebook to explain how we can load data in the ESDL and save it as zarr or netcdf format. This currently depends on yeesian/ArchGDAL.jl#167 for the use of unsafe_buildvrt.
|
This has been incorporated in #179, thank you for the contribution! |
As suggested by @visr in #164 this widens the expected types in the unsafe_gdal* functions to AbstractDataset, so that they would be usable with interactive Datasets.
I am using parametric functions, so that we reuse the input type as return type to prevent the accidental mixing of the different approaches.
I added tests for these functions by copying the tests in test_gdalutilities.jl and change the do block notation to variable assignment.
Should we also provide these functions without the unsafe keyword by defining: