Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROAM Apps path and img policy #1018

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Jan 27, 2025

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@Emily-ejag Emily-ejag requested a review from a team as a code owner January 27, 2025 20:14
@Emily-ejag Emily-ejag self-assigned this Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1278 for commit 80c9263 by the Vitest Coverage Report Action

@Emily-ejag Emily-ejag added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Visit the preview URL for this PR (updated for commit 80c9263):

https://roar-staging--pr1018-fix-roam-apps-route-3ujuv4ov.web.app

(expires Thu, 06 Feb 2025 21:47:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Jan 27, 2025

roar-dashboard-e2e    Run #10592

Run Properties:  status check passed Passed #10592  •  git commit 80c9263bbd: E2E Tests for PR 1018 "Fix ROAM Apps path and img policy" from commit "80c9263bb...
Project roar-dashboard-e2e
Branch Review fix/roam-apps-route-and-ploicy
Run status status check passed Passed #10592
Run duration 03m 04s
Commit git commit 80c9263bbd: E2E Tests for PR 1018 "Fix ROAM Apps path and img policy" from commit "80c9263bb...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎

ksmontville
ksmontville previously approved these changes Jan 27, 2025
Copy link
Collaborator

@ksmontville ksmontville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes, but we might need to address the Cypress test issues before merging.

kellyel
kellyel previously approved these changes Jan 27, 2025
@Emily-ejag Emily-ejag dismissed stale reviews from kellyel and ksmontville via 4b61013 January 27, 2025 22:59
@Emily-ejag Emily-ejag added the [qa] high priority This is a high priority QA item label Jan 27, 2025
@richford richford merged commit fa74b06 into main Jan 31, 2025
24 checks passed
@richford richford deleted the fix/roam-apps-route-and-ploicy branch January 31, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file [qa] high priority This is a high priority QA item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants