Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Content-Security-Policy #1016

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

maximilianoertel
Copy link
Collaborator

Proposed changes

This PR updates the CSP with the missing values as flagged by Sentry.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Resolves https://github.com/yeatmanlab/roar-project-management/issues/692

@maximilianoertel maximilianoertel requested a review from a team as a code owner January 24, 2025 15:55
Copy link

github-actions bot commented Jan 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1280 for commit 33c4be8 by the Vitest Coverage Report Action

@maximilianoertel maximilianoertel self-assigned this Jan 24, 2025
@maximilianoertel maximilianoertel added the enhancement New feature or request label Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

Visit the preview URL for this PR (updated for commit 33c4be8):

https://roar-staging--pr1016-enh-692-update-csp-hduzjooe.web.app

(expires Thu, 06 Feb 2025 21:55:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Jan 24, 2025

roar-dashboard-e2e    Run #10604

Run Properties:  status check passed Passed #10604  •  git commit 33c4be8e70: E2E Tests for PR 1016 "Update Content-Security-Policy" from commit "33c4be8e7066...
Project roar-dashboard-e2e
Branch Review enh/692/update-csp
Run status status check passed Passed #10604
Run duration 04m 02s
Commit git commit 33c4be8e70: E2E Tests for PR 1016 "Update Content-Security-Policy" from commit "33c4be8e7066...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

firebase.json Outdated Show resolved Hide resolved
firebase.json Outdated Show resolved Hide resolved
richford
richford previously approved these changes Jan 27, 2025
Emily-ejag
Emily-ejag previously approved these changes Jan 27, 2025
firebase.json Show resolved Hide resolved
@Emily-ejag Emily-ejag dismissed stale reviews from richford and themself via 33c4be8 January 30, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants