Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added GenVM decoder to readContract method #42

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

cristiam86
Copy link
Collaborator

Fixes #40

What

  • Added the GenVM decoder to the result obtained from the readContract method

Why

  • To allow developers to get the decoded data when calling an Intelligent Contract method

Testing done

  • Tested in the GenLayer Boilerplate project

Decisions made

The same decoder that is currently working in the GenLayer Studio has been added.

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Check that calling a contract read method, now returns a decoded object.

User facing release notes

Read contract data has been decoded so its value can be used

@cristiam86 cristiam86 linked an issue Dec 18, 2024 that may be closed by this pull request
@AgustinRamiroDiaz
Copy link
Contributor

Copy link
Contributor

@AgustinRamiroDiaz AgustinRamiroDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to unblock dKOL, but

  • I don't feel qualified to review this
  • It'd be nice to have e2e tests for this

@AgustinRamiroDiaz
Copy link
Contributor

I've also created #44 somewhat related

@cristiam86 cristiam86 merged commit 096d36d into main Dec 18, 2024
1 check passed
@cristiam86 cristiam86 deleted the 40-bug-clientreadcontract-is-not-decoding-output branch January 20, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: client.readContract is not decoding output
2 participants