feat(schedule_service): implement UpdateBackupSchedule #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulya-sidorina
force-pushed
the
feature/NBYDB-370
branch
from
b1d08a5 to
c684fe9
Compare
ulya-sidorina
force-pushed
the
feature/NBYDB-370
branch
from
c684fe9 to
09ba0d4
Compare
qrort
reviewed
Oct 4, 2024
| table_types.StringValueFromString(strings.Join(schedule.SourcePathsToExclude, ",")), | ||
| ) | ||
| } | ||
| d.AddValueParam("$paths", table_types.StringValueFromString(strings.Join(schedule.SourcePaths, ","))) |
There was a problem hiding this comment.
We need to somehow verify that for each WithUpdateBackupSchedule call, correct SourcePaths and SourcePathsToExclude are set. It is hard, maybe we need some kind of integration test for schedules, that verifies that non-empty SourcePaths are not overrided by empty strings
There was a problem hiding this comment.
I looked through the code and it seems that it is ok for now, but we need a ticket for adding schedules to integration test
qrort
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.