Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3-13-hotfix: Fix uncommitted changes leak and clean them up on startup #13487

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 17, 2025

Changelog entry

Fix uncommitted changes leak and clean them up on startup.

Changelog category

  • Bugfix

Additional information

It was discovered that uncommitted changes are slowly leaking in some workloads, which turned out to be due to writes combined with a broken read-only lock. This patch fixes the issue and adds automatic cleanup on shard startup.

Fixes #13387.

@snaury snaury self-assigned this Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 10:54:24 UTC Pre-commit check for 3e72858 has started.
2025-01-17 10:57:10 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-17 11:23:32 UTC Build successful.
2025-01-17 11:23:51 UTC Tests are running...
🔴 2025-01-17 13:35:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10342 10247 0 31 24 40

🟡 2025-01-17 13:36:06 UTC ydbd size 5.6 GiB changed* by +205.6 KiB, which is >= 100.0 KiB vs stable-24-3-13-hotfix: Warning

ydbd size dash stable-24-3-13-hotfix: 7ef8e47 merge: 3e72858 diff diff %
ydbd size 5 993 569 648 Bytes 5 993 780 208 Bytes +205.6 KiB +0.004%
ydbd stripped size 1 502 109 024 Bytes 1 502 135 104 Bytes +25.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 10:56:04 UTC Pre-commit check for 3e72858 has started.
2025-01-17 10:58:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-17 11:41:58 UTC Build successful.
2025-01-17 11:42:15 UTC Tests are running...
🔴 2025-01-17 13:07:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14644 13285 0 23 1300 36

🟡 2025-01-17 13:08:39 UTC ydbd size 8.3 GiB changed* by +478.3 KiB, which is >= 100.0 KiB vs stable-24-3-13-hotfix: Warning

ydbd size dash stable-24-3-13-hotfix: 7ef8e47 merge: 3e72858 diff diff %
ydbd size 8 861 923 472 Bytes 8 862 413 232 Bytes +478.3 KiB +0.006%
ydbd stripped size 483 802 056 Bytes 483 806 792 Bytes +4.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review January 17, 2025 13:59
@snaury snaury requested a review from a team as a code owner January 17, 2025 13:59
@snaury snaury merged commit 6d10a7a into ydb-platform:stable-24-3-13-hotfix Jan 17, 2025
6 of 10 checks passed
@snaury snaury deleted the bugfix-13387-uncommitted-tx-leak-24-3-13-hotfix branch January 17, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants