Change default compression via CSConfig #12542

vlad-gogov · 2024-12-12T06:14:56Z

Changelog entry

Changed the default compression to ZSTD with a compression level of one.
Added the ability to change the default compression through the CS configuration.
If compression is not specified for a column in a schema, plain compression will not be specified.
Added error checking if compression level is set but compression type is not specified.

Changelog category

New feature

github-actions · 2024-12-12T06:17:49Z

⚪ 2024-12-12 06:17:48 UTC Pre-commit check linux-x86_64-release-asan for 47ea561 has started.
⚪ 2024-12-12 06:18:27 UTC Artifacts will be uploaded here
⚪ 2024-12-12 06:22:17 UTC ya make is running...
🟡 2024-12-12 07:54:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15298	15236	0	14	4	44

🟢 2024-12-12 07:55:39 UTC Build successful.
🟢 2024-12-12 07:56:01 UTC ydbd size 3.6 GiB changed* by +24.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `22dd11e`	merge: `47ea561`	diff	diff %
ydbd size	3 898 431 264 Bytes	3 898 456 424 Bytes	+24.6 KiB	+0.001%
ydbd stripped size	1 366 673 680 Bytes	1 366 682 000 Bytes	+8.1 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-12T06:18:54Z

⚪ 2024-12-12 06:18:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47ea561 has started.
⚪ 2024-12-12 06:19:05 UTC Artifacts will be uploaded here
⚪ 2024-12-12 06:22:30 UTC ya make is running...
🟡 2024-12-12 07:53:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
32797	29871	0	2	2812	112

⚪ 2024-12-12 07:56:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 08:08:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
747 (only retried tests)	639	0	1	0	107

⚪ 2024-12-12 08:08:42 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-12 08:20:33 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
668 (only retried tests)	560	0	1	0	107

🟢 2024-12-12 08:20:42 UTC Build successful.
🟢 2024-12-12 08:21:02 UTC ydbd size 2.1 GiB changed* by +12.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `22dd11e`	merge: `47ea561`	diff	diff %
ydbd size	2 256 167 104 Bytes	2 256 180 160 Bytes	+12.8 KiB	+0.001%
ydbd stripped size	483 930 096 Bytes	483 931 536 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-19T03:50:10Z

⚪ 2024-12-19 03:50:10 UTC Pre-commit check linux-x86_64-release-asan for 20db886 has started.
⚪ 2024-12-19 03:50:20 UTC Artifacts will be uploaded here
⚪ 2024-12-19 03:53:33 UTC ya make is running...
🟡 2024-12-19 05:27:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14032	13920	0	60	5	47

🟢 2024-12-19 05:29:16 UTC Build successful.
🟢 2024-12-19 05:29:38 UTC ydbd size 3.6 GiB changed* by +6.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `3317b75`	merge: `20db886`	diff	diff %
ydbd size	3 895 809 416 Bytes	3 895 815 936 Bytes	+6.4 KiB	+0.000%
ydbd stripped size	1 364 187 216 Bytes	1 364 188 048 Bytes	+832 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-19T03:50:22Z

⚪ 2024-12-19 03:50:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 20db886 has started.
⚪ 2024-12-19 03:50:34 UTC Artifacts will be uploaded here
⚪ 2024-12-19 03:53:48 UTC ya make is running...
🟡 2024-12-19 05:20:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
31042	28096	0	1	2830	115

⚪ 2024-12-19 05:23:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-19 05:35:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
160 (only retried tests)	51	0	0	0	109

🟢 2024-12-19 05:35:11 UTC Build successful.
🟢 2024-12-19 05:35:29 UTC ydbd size 2.1 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `3317b75`	merge: `20db886`	diff	diff %
ydbd size	2 254 471 696 Bytes	2 254 479 616 Bytes	+7.7 KiB	+0.000%
ydbd stripped size	483 160 496 Bytes	483 161 008 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-19T12:06:04Z

⚪ 2024-12-19 12:06:04 UTC Pre-commit check linux-x86_64-release-asan for 3f46e73 has started.
⚪ 2024-12-19 12:06:15 UTC Artifacts will be uploaded here
⚫ 2024-12-19 12:07:45 UTC Check cancelled

github-actions · 2024-12-19T12:06:05Z

⚪ 2024-12-19 12:06:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f46e73 has started.
⚪ 2024-12-19 12:06:38 UTC Artifacts will be uploaded here
⚫ 2024-12-19 12:07:45 UTC Check cancelled

github-actions · 2024-12-19T12:09:14Z

⚪ 2024-12-19 12:09:13 UTC Pre-commit check linux-x86_64-release-asan for dea31d1 has started.
⚪ 2024-12-19 12:09:17 UTC Artifacts will be uploaded here
⚪ 2024-12-19 12:12:26 UTC ya make is running...
🟡 2024-12-19 13:59:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14033	13733	0	229	22	49

🟢 2024-12-19 14:01:08 UTC Build successful.
🟢 2024-12-19 14:01:38 UTC ydbd size 3.6 GiB changed* by +98.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d48cc77`	merge: `dea31d1`	diff	diff %
ydbd size	3 865 219 656 Bytes	3 865 320 360 Bytes	+98.3 KiB	+0.003%
ydbd stripped size	1 350 327 184 Bytes	1 350 342 864 Bytes	+15.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-19T12:09:15Z

⚪ 2024-12-19 12:09:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for dea31d1 has started.
⚪ 2024-12-19 12:09:19 UTC Artifacts will be uploaded here
⚪ 2024-12-19 12:12:49 UTC ya make is running...
🟡 2024-12-19 13:44:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
31047	27854	0	245	2833	115

⚪ 2024-12-19 13:47:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-19 13:59:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
549 (only retried tests)	195	0	244	0	110

⚪ 2024-12-19 14:00:14 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-19 14:12:37 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
542 (only retried tests)	188	0	244	0	110

🟢 2024-12-19 14:12:50 UTC Build successful.
🟢 2024-12-19 14:13:16 UTC ydbd size 2.1 GiB changed* by +54.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `14c83d5`	merge: `dea31d1`	diff	diff %
ydbd size	2 234 561 384 Bytes	2 234 617 040 Bytes	+54.4 KiB	+0.002%
ydbd stripped size	477 801 392 Bytes	477 802 416 Bytes	+1.0 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-20T06:15:14Z

⚪ 2024-12-20 06:15:14 UTC Pre-commit check linux-x86_64-release-asan for da271dc has started.
⚪ 2024-12-20 06:15:25 UTC Artifacts will be uploaded here
⚪ 2024-12-20 06:18:35 UTC ya make is running...
⚫ 2024-12-20 07:37:07 UTC Check cancelled

github-actions · 2024-12-20T06:15:42Z

⚪ 2024-12-20 06:15:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for da271dc has started.
⚪ 2024-12-20 06:15:53 UTC Artifacts will be uploaded here
⚪ 2024-12-20 06:19:05 UTC ya make is running...
⚫ 2024-12-20 07:37:10 UTC Check cancelled

ydb/core/config/validation/column_shard_config_validator.cpp

github-actions · 2024-12-20T07:38:58Z

⚪ 2024-12-20 07:38:57 UTC Pre-commit check linux-x86_64-release-asan for cbaa9d1 has started.
⚪ 2024-12-20 07:39:35 UTC Artifacts will be uploaded here
⚪ 2024-12-20 07:43:18 UTC ya make is running...
🟡 2024-12-20 08:44:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14044	13829	0	164	4	47

🟢 2024-12-20 08:45:16 UTC Build successful.
🟢 2024-12-20 08:45:40 UTC ydbd size 3.6 GiB changed* by +71.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `3f79dce`	merge: `cbaa9d1`	diff	diff %
ydbd size	3 865 560 136 Bytes	3 865 633 232 Bytes	+71.4 KiB	+0.002%
ydbd stripped size	1 350 398 032 Bytes	1 350 414 544 Bytes	+16.1 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-20T07:41:19Z

⚪ 2024-12-20 07:41:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for cbaa9d1 has started.
⚪ 2024-12-20 07:41:30 UTC Artifacts will be uploaded here
⚪ 2024-12-20 07:44:48 UTC ya make is running...
🟡 2024-12-20 08:46:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
31067	27875	0	245	2831	116

⚪ 2024-12-20 08:48:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-20 09:01:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
547 (only retried tests)	193	0	243	0	111

⚪ 2024-12-20 09:01:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-20 09:13:47 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
540 (only retried tests)	186	0	243	0	111

🟢 2024-12-20 09:13:58 UTC Build successful.
🟢 2024-12-20 09:14:26 UTC ydbd size 2.1 GiB changed* by +31.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `6ea7dea`	merge: `cbaa9d1`	diff	diff %
ydbd size	2 234 739 552 Bytes	2 234 771 536 Bytes	+31.2 KiB	+0.001%
ydbd stripped size	477 819 280 Bytes	477 821 392 Bytes	+2.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-20T10:37:19Z

⚪ 2024-12-20 10:37:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c88b58 has started.
⚪ 2024-12-20 10:37:30 UTC Artifacts will be uploaded here
⚪ 2024-12-20 10:40:44 UTC ya make is running...
🟡 2024-12-20 12:11:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
31068	28020	0	103	2832	113

⚪ 2024-12-20 12:13:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-20 12:18:50 UTC ydbd size 2.1 GiB changed* by +48.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `291222e`	merge: `7c88b58`	diff	diff %
ydbd size	2 234 869 408 Bytes	2 234 918 624 Bytes	+48.1 KiB	+0.002%
ydbd stripped size	477 835 088 Bytes	477 837 072 Bytes	+1.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-12-20 12:18:52 UTC Check cancelled

github-actions · 2024-12-20T10:37:19Z

⚪ 2024-12-20 10:37:19 UTC Pre-commit check linux-x86_64-release-asan for 7c88b58 has started.
⚪ 2024-12-20 10:37:30 UTC Artifacts will be uploaded here
⚪ 2024-12-20 10:40:40 UTC ya make is running...
🟡 2024-12-20 12:19:04 UTC ydbd size 3.6 GiB changed* by +109.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `291222e`	merge: `7c88b58`	diff	diff %
ydbd size	3 865 748 784 Bytes	3 865 861 216 Bytes	+109.8 KiB	+0.003%
ydbd stripped size	1 350 424 624 Bytes	1 350 441 520 Bytes	+16.5 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-12-20 12:19:05 UTC Check cancelled

github-actions · 2024-12-20T12:22:10Z

⚪ 2024-12-20 12:22:10 UTC Pre-commit check linux-x86_64-release-asan for a5ed3b5 has started.
⚪ 2024-12-20 12:22:21 UTC Artifacts will be uploaded here
⚪ 2024-12-20 12:25:46 UTC ya make is running...
🟡 2024-12-20 14:10:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14056	13979	0	24	6	47

🟢 2024-12-20 14:11:34 UTC Build successful.
🟡 2024-12-20 14:11:58 UTC ydbd size 3.6 GiB changed* by +109.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `b375d19`	merge: `a5ed3b5`	diff	diff %
ydbd size	3 866 106 856 Bytes	3 866 219 120 Bytes	+109.6 KiB	+0.003%
ydbd stripped size	1 350 473 360 Bytes	1 350 494 416 Bytes	+20.6 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-13T12:02:34Z

⚪ 2025-01-13 12:02:33 UTC Pre-commit check linux-x86_64-release-asan for 620af9f has started.
⚪ 2025-01-13 12:03:00 UTC Artifacts will be uploaded here
⚪ 2025-01-13 12:06:37 UTC ya make is running...
🟡 2025-01-13 13:19:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12102	11907	0	164	4	27

⚪ 2025-01-13 13:20:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-13 13:32:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
366 (only retried tests)	196	0	143	2	25

⚪ 2025-01-13 13:33:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-13 13:45:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
325 (only retried tests)	155	0	143	1	26

🟢 2025-01-13 13:45:32 UTC Build successful.
🟢 2025-01-13 13:46:05 UTC ydbd size 3.6 GiB changed* by +36.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fef7e41`	merge: `620af9f`	diff	diff %
ydbd size	3 893 426 136 Bytes	3 893 463 040 Bytes	+36.0 KiB	+0.001%
ydbd stripped size	1 360 222 224 Bytes	1 360 229 200 Bytes	+6.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-13T12:03:13Z

⚪ 2025-01-13 12:03:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 620af9f has started.
⚪ 2025-01-13 12:03:40 UTC Artifacts will be uploaded here
⚪ 2025-01-13 12:07:17 UTC ya make is running...
🟡 2025-01-13 13:08:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
26027	23266	0	258	2380	123

⚪ 2025-01-13 13:10:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-13 13:24:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
586 (only retried tests)	222	0	245	0	119

⚪ 2025-01-13 13:24:34 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-13 13:37:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
562 (only retried tests)	198	0	245	0	119

🟢 2025-01-13 13:37:49 UTC Build successful.
🟢 2025-01-13 13:38:19 UTC ydbd size 2.1 GiB changed* by +13.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `a5e59f3`	merge: `620af9f`	diff	diff %
ydbd size	2 245 791 272 Bytes	2 245 804 968 Bytes	+13.4 KiB	+0.001%
ydbd stripped size	472 639 824 Bytes	472 640 528 Bytes	+704 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-14T04:24:31Z

⚪ 2025-01-14 04:24:30 UTC Pre-commit check linux-x86_64-release-asan for 8070626 has started.
⚪ 2025-01-14 04:24:42 UTC Artifacts will be uploaded here
⚪ 2025-01-14 04:28:00 UTC ya make is running...
⚫ 2025-01-14 04:35:58 UTC Check cancelled

github-actions · 2025-01-14T04:25:20Z

⚪ 2025-01-14 04:25:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8070626 has started.
⚪ 2025-01-14 04:25:24 UTC Artifacts will be uploaded here
⚪ 2025-01-14 04:28:42 UTC ya make is running...
⚫ 2025-01-14 04:35:58 UTC Check cancelled

github-actions · 2025-01-14T04:38:07Z

⚪ 2025-01-14 04:38:06 UTC Pre-commit check linux-x86_64-release-asan for aedacbf has started.
⚪ 2025-01-14 04:38:19 UTC Artifacts will be uploaded here
⚪ 2025-01-14 04:41:33 UTC ya make is running...
🟡 2025-01-14 06:03:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13441	13390	0	21	3	27

⚪ 2025-01-14 06:08:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-14 06:20:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
83 (only retried tests)	56	0	2	0	25

⚪ 2025-01-14 06:20:27 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-14 06:24:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
52 (only retried tests)	27	0	1	0	24

🟢 2025-01-14 06:24:11 UTC Build successful.
🟢 2025-01-14 06:24:38 UTC ydbd size 3.6 GiB changed* by +18.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc474d1`	merge: `aedacbf`	diff	diff %
ydbd size	3 893 453 432 Bytes	3 893 472 032 Bytes	+18.2 KiB	+0.000%
ydbd stripped size	1 360 226 992 Bytes	1 360 185 584 Bytes	-40.4 KiB	-0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-14T04:39:50Z

⚪ 2025-01-14 04:39:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for aedacbf has started.
⚪ 2025-01-14 04:40:02 UTC Artifacts will be uploaded here
⚪ 2025-01-14 04:43:12 UTC ya make is running...
🟡 2025-01-14 06:00:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
27380	24875	0	2	2380	123

⚪ 2025-01-14 06:09:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-14 06:20:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
179 (only retried tests)	61	0	0	0	118

🟢 2025-01-14 06:21:00 UTC Build successful.
🟢 2025-01-14 06:21:18 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc474d1`	merge: `aedacbf`	diff	diff %
ydbd size	2 245 809 440 Bytes	2 245 830 296 Bytes	+20.4 KiB	+0.001%
ydbd stripped size	472 640 144 Bytes	472 631 504 Bytes	-8.4 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-14T06:53:50Z

⚪ 2025-01-14 06:53:50 UTC Pre-commit check linux-x86_64-release-asan for c1b89d0 has started.
⚪ 2025-01-14 06:54:02 UTC Artifacts will be uploaded here
⚪ 2025-01-14 06:57:19 UTC ya make is running...
🟡 2025-01-14 07:57:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13440	13385	0	24	4	27

⚪ 2025-01-14 07:58:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-14 08:10:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
89 (only retried tests)	62	0	1	1	25

⚪ 2025-01-14 08:10:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-14 08:28:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
49 (only retried tests)	23	0	1	0	25

🟢 2025-01-14 08:28:53 UTC Build successful.
🟢 2025-01-14 08:29:23 UTC ydbd size 3.6 GiB changed* by +18.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc474d1`	merge: `c1b89d0`	diff	diff %
ydbd size	3 893 453 432 Bytes	3 893 472 032 Bytes	+18.2 KiB	+0.000%
ydbd stripped size	1 360 226 992 Bytes	1 360 185 584 Bytes	-40.4 KiB	-0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-14T06:54:03Z

⚪ 2025-01-14 06:54:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for c1b89d0 has started.
⚪ 2025-01-14 06:54:14 UTC Artifacts will be uploaded here
⚪ 2025-01-14 06:57:28 UTC ya make is running...
🟡 2025-01-14 07:51:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
27380	24866	0	3	2382	129

⚪ 2025-01-14 07:53:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-14 08:05:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
197 (only retried tests)	76	0	0	0	121

🟢 2025-01-14 08:06:04 UTC Build successful.
🟢 2025-01-14 08:06:30 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `fc474d1`	merge: `c1b89d0`	diff	diff %
ydbd size	2 245 809 440 Bytes	2 245 830 296 Bytes	+20.4 KiB	+0.001%
ydbd stripped size	472 640 144 Bytes	472 631 504 Bytes	-8.4 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

swalrus1 · 2025-01-14T13:01:49Z

ydb/core/base/appdata_fwd.h

 }

 inline TAppData& AppDataVerified() {
    Y_ABORT_UNLESS(HasAppData());
    auto& actorSystem = NActors::TlsActivationContext->ExecutorThread.ActorSystem;
-    Y_ABORT_UNLESS(actorSystem);


Зачем уносить проверки в HasAppData? Может быть так, что TlsActivationContext есть, но в нём нет AppData?

У меня получилась ситация, HasAppData возвращает true, но AppData в нем нет, поэтому я не мог обратиться к конфигурации CS, падало на

ydb/ydb/core/base/appdata_fwd.h

Line 308 in de2a1e3

Y_ABORT_UNLESS(x && x->Magic == TAppData::MagicTag);

(переменная x была пустая), поэтому я подумал, что проверка HasAppData должна проверять наличие AppData

swalrus1 · 2025-01-14T13:17:44Z

ydb/core/formats/arrow/serializer/native.h

+            return NArrow::TStatusValidator::GetValid(
+                arrow::util::Codec::Create(codec, AppData()->ColumnShardConfig.GetDefaultCompressionLevel()));
+        } else if (codec == arrow::Compression::ZSTD) {
+            return NArrow::TStatusValidator::GetValid(arrow::util::Codec::Create(codec, 1));


Зачем хардкодить дефолтный compression level для ZTDS? Create(codec) не выставит нужное значение по-умолчанию?

Create(codec) по умолчанию создает ZSTD с compression level равным 8

А как ты это понял? Просто в коде arrow значением по умолчанию для ZSTD стоит 1: https://github.com/ydb-platform/ydb/blob/main/contrib/libs/apache/arrow/cpp/src/arrow/util/compression_internal.h#L73

github-actions · 2025-01-15T08:31:15Z

⚪ 2025-01-15 08:31:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7494cad has started.
⚪ 2025-01-15 08:31:28 UTC Artifacts will be uploaded here
⚪ 2025-01-15 08:34:38 UTC ya make is running...
🟡 2025-01-15 09:35:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
26038	23432	0	103	2380	123

⚪ 2025-01-15 09:37:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 09:59:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
291 (only retried tests)	69	0	63	38	121

⚪ 2025-01-15 09:59:38 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-15 10:11:50 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
281 (only retried tests)	61	0	99	0	121

🟢 2025-01-15 10:12:01 UTC Build successful.
🟢 2025-01-15 10:12:26 UTC ydbd size 2.1 GiB changed* by +29.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b7192f6`	merge: `7494cad`	diff	diff %
ydbd size	2 247 465 736 Bytes	2 247 496 336 Bytes	+29.9 KiB	+0.001%
ydbd stripped size	472 858 544 Bytes	472 858 928 Bytes	+384 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-15T08:31:28Z

⚪ 2025-01-15 08:31:28 UTC Pre-commit check linux-x86_64-release-asan for 7494cad has started.
⚪ 2025-01-15 08:31:40 UTC Artifacts will be uploaded here
⚪ 2025-01-15 08:34:48 UTC ya make is running...
🟡 2025-01-15 09:40:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12109	12055	0	18	9	27

⚪ 2025-01-15 09:41:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 10:01:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
86 (only retried tests)	55	0	4	1	26

⚪ 2025-01-15 10:01:14 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-15 10:13:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
54 (only retried tests)	25	0	3	0	26

🟢 2025-01-15 10:13:39 UTC Build successful.
🟢 2025-01-15 10:14:13 UTC ydbd size 3.6 GiB changed* by +66.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b7192f6`	merge: `7494cad`	diff	diff %
ydbd size	3 895 388 520 Bytes	3 895 456 544 Bytes	+66.4 KiB	+0.002%
ydbd stripped size	1 360 960 784 Bytes	1 360 965 136 Bytes	+4.2 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-15T12:08:41Z

⚪ 2025-01-15 12:08:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for f21093e has started.
⚪ 2025-01-15 12:08:52 UTC Artifacts will be uploaded here
⚪ 2025-01-15 12:12:01 UTC ya make is running...
🟡 2025-01-15 13:38:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
27392	24879	0	7	2380	126

⚪ 2025-01-15 13:40:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 13:53:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
191 (only retried tests)	71	0	2	0	118

⚪ 2025-01-15 13:53:12 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-15 14:06:10 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
174 (only retried tests)	57	0	1	0	116

🟢 2025-01-15 14:06:18 UTC Build successful.
🟢 2025-01-15 14:06:42 UTC ydbd size 2.1 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4959d3e`	merge: `f21093e`	diff	diff %
ydbd size	2 247 494 784 Bytes	2 247 508 392 Bytes	+13.3 KiB	+0.001%
ydbd stripped size	472 865 744 Bytes	472 857 104 Bytes	-8.4 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-15T12:08:51Z

⚪ 2025-01-15 12:08:50 UTC Pre-commit check linux-x86_64-release-asan for f21093e has started.
⚪ 2025-01-15 12:09:03 UTC Artifacts will be uploaded here
⚪ 2025-01-15 12:12:12 UTC ya make is running...
🟡 2025-01-15 13:51:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13451	13383	0	26	15	27

⚪ 2025-01-15 13:52:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 14:05:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
111 (only retried tests)	84	0	1	0	26

⚪ 2025-01-15 14:05:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-15 14:17:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
49 (only retried tests)	23	0	1	1	24

🟢 2025-01-15 14:17:30 UTC Build successful.
🟢 2025-01-15 14:18:00 UTC ydbd size 3.6 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4959d3e`	merge: `f21093e`	diff	diff %
ydbd size	3 895 426 488 Bytes	3 895 440 120 Bytes	+13.3 KiB	+0.000%
ydbd stripped size	1 360 971 952 Bytes	1 360 934 704 Bytes	-36.4 KiB	-0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

vlad-gogov self-assigned this Dec 12, 2024

github-actions bot added the new-feature label Dec 12, 2024

vlad-gogov force-pushed the default_compression_in_config branch 2 times, most recently from 944f137 to 1e64839 Compare December 19, 2024 03:46

vlad-gogov marked this pull request as ready for review December 19, 2024 07:32

vlad-gogov force-pushed the default_compression_in_config branch from 1e64839 to f1e3c60 Compare December 19, 2024 12:02

vlad-gogov requested a review from a team as a code owner December 19, 2024 12:02

vlad-gogov force-pushed the default_compression_in_config branch from f1e3c60 to 6ee9696 Compare December 19, 2024 12:07

vlad-gogov force-pushed the default_compression_in_config branch 2 times, most recently from a1f0a3f to 74572a2 Compare December 20, 2024 06:12

Enjection requested changes Dec 20, 2024

View reviewed changes

ydb/core/config/validation/column_shard_config_validator.cpp Outdated Show resolved Hide resolved

vlad-gogov requested a review from Enjection December 20, 2024 07:37

Enjection previously approved these changes Dec 20, 2024

View reviewed changes

vlad-gogov dismissed Enjection’s stale review via 7fb27d0 December 20, 2024 10:33

vlad-gogov force-pushed the default_compression_in_config branch from 7fb27d0 to c34b4b8 Compare December 20, 2024 10:34

vlad-gogov force-pushed the default_compression_in_config branch from 3bade5e to 9b76d93 Compare January 13, 2025 12:00

vlad-gogov added 6 commits January 14, 2025 04:35

implemented without test

383db7f

fix

d6ecc91

fix

3e28787

test

b3a9d1a

fix

e62eef1

fix

c00d144

vlad-gogov force-pushed the default_compression_in_config branch from f672824 to c00d144 Compare January 14, 2025 04:35

fix test and delete debug messages

db36b0a

github-actions bot added new-feature and removed new-feature labels Jan 14, 2025

swalrus1 requested changes Jan 14, 2025

View reviewed changes

vlad-gogov changed the title ~~Set default compression via CSConfig~~ Change default compression via CSConfig Jan 15, 2025

github-actions bot added new-feature and removed new-feature labels Jan 15, 2025

revert changes

dc5c43d

resolve conversations

f94e573

swalrus1 approved these changes Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default compression via CSConfig #12542

Change default compression via CSConfig #12542

vlad-gogov commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

swalrus1 Jan 14, 2025

vlad-gogov Jan 15, 2025

swalrus1 Jan 14, 2025

vlad-gogov Jan 15, 2025

swalrus1 Jan 15, 2025

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

Change default compression via CSConfig #12542

Are you sure you want to change the base?

Change default compression via CSConfig #12542

Conversation

vlad-gogov commented Dec 12, 2024 • edited Loading

Changelog entry

Changelog category

github-actions bot commented Dec 12, 2024 • edited Loading

github-actions bot commented Dec 12, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Dec 20, 2024 • edited Loading

github-actions bot commented Jan 13, 2025 • edited Loading

github-actions bot commented Jan 13, 2025 • edited Loading

github-actions bot commented Jan 14, 2025 • edited Loading

github-actions bot commented Jan 14, 2025 • edited Loading

github-actions bot commented Jan 14, 2025 • edited Loading

github-actions bot commented Jan 14, 2025 • edited Loading

github-actions bot commented Jan 14, 2025 • edited Loading

github-actions bot commented Jan 14, 2025 • edited Loading

swalrus1 Jan 14, 2025

Choose a reason for hiding this comment

vlad-gogov Jan 15, 2025

Choose a reason for hiding this comment

swalrus1 Jan 14, 2025

Choose a reason for hiding this comment

vlad-gogov Jan 15, 2025

Choose a reason for hiding this comment

swalrus1 Jan 15, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 15, 2025 • edited Loading

github-actions bot commented Jan 15, 2025 • edited Loading

github-actions bot commented Jan 15, 2025 • edited Loading

github-actions bot commented Jan 15, 2025 • edited Loading

vlad-gogov commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading