Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch mock to uber fork of gomock #999

Merged
merged 2 commits into from
Jan 20, 2024
Merged

switch mock to uber fork of gomock #999

merged 2 commits into from
Jan 20, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Jan 12, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@rekby rekby marked this pull request as ready for review January 12, 2024 13:34
Copy link

github-actions bot commented Jan 12, 2024

summary

Base version: v3.54.4-0.20240118083444-669aaf2dff2e (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.3.

@rekby rekby marked this pull request as draft January 12, 2024 13:34
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (669aaf2) 67.42% compared to head (4257c72) 67.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   67.42%   67.53%   +0.11%     
==========================================
  Files         252      252              
  Lines       24509    24509              
==========================================
+ Hits        16524    16551      +27     
+ Misses       7118     7095      -23     
+ Partials      867      863       -4     
Flag Coverage Δ
54.03% <ø> (+0.09%) ⬆️
go-1.20.x 67.49% <ø> (+0.07%) ⬆️
go-1.21.x 67.21% <ø> (-0.15%) ⬇️
integration 54.03% <ø> (+0.09%) ⬆️
macOS 38.81% <ø> (+<0.01%) ⬆️
ubuntu 38.82% <ø> (-0.04%) ⬇️
unit 38.93% <ø> (-0.01%) ⬇️
windows 38.90% <ø> (+0.02%) ⬆️
ydb-22.5 53.43% <ø> (-0.20%) ⬇️
ydb-23.1 53.57% <ø> (-0.10%) ⬇️
ydb-23.2 53.76% <ø> (+0.05%) ⬆️
ydb-23.3 53.67% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby changed the title switch one mock to typed switch mock to uber fork of gomock Jan 19, 2024
@rekby rekby marked this pull request as ready for review January 19, 2024 15:30
@rekby rekby merged commit a533017 into master Jan 20, 2024
42 checks passed
@rekby rekby deleted the switch-mock branch January 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants