Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Topic.DescribeTopicConsumer #1508

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

qrort
Copy link
Collaborator

@qrort qrort commented Oct 14, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

It is impossible to get detailed topic consumer information. in YDB CLI, there is topic consumer describe method that allows user to get read/write lag timings, amount of read bytes per customer ets.

Issue Number: N/A

What is the new behavior?

Topic client got DescribeTopicConsumer method that performs corresponding GRPC call to YDB and returns the data with minimal modification.

Other information

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 57.06522% with 79 lines in your changes missing coverage. Please review.

Project coverage is 66.99%. Comparing base (84a2b9b) to head (6503633).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/grpcwrapper/rawtopic/describe_consumer.go 40.84% 36 Missing and 6 partials ⚠️
internal/topic/topicclientinternal/client.go 60.00% 12 Missing and 2 partials ⚠️
internal/grpcwrapper/rawtopic/client.go 23.52% 12 Missing and 1 partial ⚠️
internal/grpcwrapper/rawoptional/rawoptional.go 52.63% 9 Missing ⚠️
topic/topicoptions/topicoptions_describe.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage   67.07%   66.99%   -0.08%     
==========================================
  Files         353      355       +2     
  Lines       36825    37006     +181     
==========================================
+ Hits        24700    24792      +92     
- Misses      11033    11110      +77     
- Partials     1092     1104      +12     
Flag Coverage Δ
experiment 71.13% <66.22%> (-0.19%) ⬇️
go-1.21.x 67.21% <59.41%> (-0.14%) ⬇️
go-1.22.x 64.90% <57.06%> (-0.16%) ⬇️
go-1.23.x 66.94% <57.06%> (-0.12%) ⬇️
integration 53.40% <64.90%> (-0.04%) ⬇️
macOS 40.74% <27.15%> (-0.08%) ⬇️
ubuntu 71.32% <66.22%> (-0.07%) ⬇️
unit 41.16% <25.00%> (-0.10%) ⬇️
windows 41.16% <25.00%> (-0.09%) ⬇️
ydb-23.3 48.84% <64.90%> (-0.09%) ⬇️
ydb-24.1 53.31% <64.90%> (-0.03%) ⬇️
ydb-24.2 52.98% <64.90%> (-0.39%) ⬇️
ydb-nightly 71.13% <66.22%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qrort qrort force-pushed the describe-topic-consumer branch 5 times, most recently from a11512c to a2c1bf2 Compare October 15, 2024 13:09
@qrort qrort force-pushed the describe-topic-consumer branch from a2c1bf2 to 6503633 Compare October 15, 2024 13:20
@rekby rekby merged commit dfe2ad8 into ydb-platform:master Oct 15, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants