Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added meta.WithTraceParent context modifier for explicit putting traceparent header into grpc calls #1499

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

github.com/ydb-platform/ydb-go-sdk/v3/meta

compatible changes

WithTraceParent: added

summary

Base version: v3.83.0 (master)
Suggested version: v3.84.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (74e831e) to head (fe2b776).

Files with missing lines Patch % Lines
meta/context.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   67.01%   66.91%   -0.11%     
==========================================
  Files         353      353              
  Lines       36822    36826       +4     
==========================================
- Hits        24676    24641      -35     
- Misses      11059    11089      +30     
- Partials     1087     1096       +9     
Flag Coverage Δ
experiment 71.04% <50.00%> (-0.16%) ⬇️
go-1.21.x 67.17% <50.00%> (-0.10%) ⬇️
go-1.22.x 64.85% <50.00%> (-0.11%) ⬇️
go-1.23.x 66.87% <50.00%> (-0.12%) ⬇️
integration 53.06% <50.00%> (-0.13%) ⬇️
macOS 40.79% <0.00%> (-0.04%) ⬇️
ubuntu 71.19% <50.00%> (-0.13%) ⬇️
unit 41.24% <0.00%> (-0.03%) ⬇️
windows 41.21% <0.00%> (-0.04%) ⬇️
ydb-23.3 46.55% <50.00%> (-0.23%) ⬇️
ydb-24.1 52.95% <50.00%> (-0.20%) ⬇️
ydb-24.2 52.97% <50.00%> (-0.17%) ⬇️
ydb-nightly 71.04% <50.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 1cbd70c into master Oct 8, 2024
44 checks passed
@asmyasnikov asmyasnikov deleted the traceparent branch October 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants