Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fixed nil pointer dereference panic on failed ydb.Open #1486

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the bug Something isn't working label Sep 26, 2024
@asmyasnikov asmyasnikov self-assigned this Sep 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.81%. Comparing base (d6b0468) to head (e69f7ab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1486      +/-   ##
==========================================
- Coverage   66.92%   66.81%   -0.11%     
==========================================
  Files         353      353              
  Lines       36670    36671       +1     
==========================================
- Hits        24541    24502      -39     
- Misses      11049    11084      +35     
- Partials     1080     1085       +5     
Flag Coverage Δ
experiment 70.94% <100.00%> (-0.18%) ⬇️
go-1.21.x 67.07% <100.00%> (-0.11%) ⬇️
go-1.22.x 64.72% <100.00%> (-0.14%) ⬇️
go-1.23.x 66.77% <100.00%> (-0.14%) ⬇️
integration 52.93% <100.00%> (-0.13%) ⬇️
macOS 40.76% <0.00%> (-0.01%) ⬇️
ubuntu 71.09% <100.00%> (-0.14%) ⬇️
unit 41.18% <0.00%> (-0.01%) ⬇️
windows 41.18% <0.00%> (-0.01%) ⬇️
ydb-23.3 46.40% <100.00%> (-0.15%) ⬇️
ydb-24.1 52.89% <100.00%> (-0.13%) ⬇️
ydb-24.2 52.85% <100.00%> (-0.13%) ⬇️
ydb-nightly 70.94% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

summary

Base version: v3.81.1-0.20240926100754-d6b04684ca90 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.81.0.

@rekby rekby self-requested a review September 26, 2024 14:42
@rekby rekby merged commit 09ca0b0 into master Sep 26, 2024
44 checks passed
@rekby rekby deleted the fix-panic branch September 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants