Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes with linters #1482

Closed
wants to merge 1 commit into from
Closed

fixes with linters #1482

wants to merge 1 commit into from

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 25, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

summary

Base version: v3.80.11-0.20240920184835-98f75f007afc (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.10.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (98f75f0) to head (198cf9f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
- Coverage   70.27%   66.77%   -3.50%     
==========================================
  Files         353      353              
  Lines       36787    36613     -174     
==========================================
- Hits        25852    24450    -1402     
- Misses       9858    11079    +1221     
- Partials     1077     1084       +7     
Flag Coverage Δ
experiment 70.89% <ø> (-0.24%) ⬇️
go-1.21.x 67.04% <ø> (-0.15%) ⬇️
go-1.22.x 64.75% <ø> (-0.11%) ⬇️
go-1.23.x 66.71% <ø> (-3.57%) ⬇️
integration 52.89% <ø> (+1.24%) ⬆️
macOS 40.70% <ø> (-0.03%) ⬇️
ubuntu 71.06% <ø> (+4.00%) ⬆️
unit 41.13% <ø> (-0.02%) ⬇️
windows 41.12% <ø> (-0.02%) ⬇️
ydb-23.3 46.39% <ø> (-0.16%) ⬇️
ydb-24.1 52.58% <ø> (-0.41%) ⬇️
ydb-24.2 52.80% <ø> (+1.17%) ⬆️
ydb-nightly 70.89% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby closed this Sep 25, 2024
@rekby rekby deleted the write-error-comment branch September 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants