Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write message in transaction #1479

Merged
merged 15 commits into from
Sep 20, 2024
Merged

Write message in transaction #1479

merged 15 commits into from
Sep 20, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 20, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github-actions bot commented Sep 20, 2024

github.com/ydb-platform/ydb-go-sdk/v3/topic

incompatible changes

Client.StartTransactionalWriter: added

github.com/ydb-platform/ydb-go-sdk/v3/topic/topicwriter

incompatible changes

NewWriter: changed from func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.Writer) *Writer to func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.WriterReconnector) *Writer

compatible changes

NewTxWriterInternal: added
TxWriter: added
WriteOption: added

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

TopicWriterResultMessagesInfoAcks.GetAcks: changed from func() struct{AcksCount int; SeqNoMin int64; SeqNoMax int64; WrittenOffsetMin int64; WrittenOffsetMax int64; WrittenCount int; SkipCount int} to func() struct{AcksCount int; SeqNoMin int64; SeqNoMax int64; WrittenOffsetMin int64; WrittenOffsetMax int64; WrittenCount int; WrittenInTxCount int; SkipCount int}

compatible changes

Topic.OnWriterAfterFinishTransaction: added
Topic.OnWriterBeforeCommitTransaction: added
TopicOnWriterAfterFinishTransaction: added
TopicOnWriterAfterFinishTransactionDoneInfo: added
TopicOnWriterAfterFinishTransactionStartInfo: added
TopicOnWriterBeforeCommitTransaction: added
TopicOnWriterBeforeCommitTransactionDoneInfo: added
TopicOnWriterBeforeCommitTransactionStartInfo: added

summary

Base version: v3.80.11-0.20240920171941-daf61dd6ea97 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.10.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 49.74874% with 100 lines in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (daf61dd) to head (1c9e3b5).

Files with missing lines Patch % Lines
log/topic.go 12.50% 26 Missing and 2 partials ⚠️
internal/query/transaction.go 40.00% 15 Missing and 3 partials ⚠️
topic/topicwriter/topicwriter.go 30.00% 14 Missing ⚠️
...al/topic/topicwriterinternal/writer_transaction.go 72.72% 10 Missing and 2 partials ⚠️
internal/topic/topicclientinternal/client.go 54.54% 7 Missing and 3 partials ⚠️
...al/grpcwrapper/rawtopic/rawtopicwriter/messages.go 33.33% 8 Missing ⚠️
...al/topic/topicwriterinternal/writer_reconnector.go 69.56% 5 Missing and 2 partials ⚠️
...grpcwrapper/rawtopic/rawtopiccommon/transaction.go 75.00% 2 Missing ⚠️
.../topic/topicwriterinternal/writer_single_stream.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
- Coverage   67.92%   66.85%   -1.08%     
==========================================
  Files         352      353       +1     
  Lines       36482    36613     +131     
==========================================
- Hits        24779    24476     -303     
- Misses      10616    11054     +438     
+ Partials     1087     1083       -4     
Flag Coverage Δ
experiment 70.94% <58.92%> (-1.22%) ⬇️
go-1.21.x 67.09% <18.97%> (-1.08%) ⬇️
go-1.22.x 64.78% <18.59%> (-0.94%) ⬇️
go-1.23.x 66.80% <49.74%> (-1.06%) ⬇️
integration 52.96% <19.64%> (-1.17%) ⬇️
macOS 40.71% <16.07%> (-0.18%) ⬇️
ubuntu 71.15% <58.92%> (-1.23%) ⬇️
unit 41.13% <13.56%> (-0.19%) ⬇️
windows 41.12% <13.56%> (-0.19%) ⬇️
ydb-23.3 46.47% <16.66%> (-1.06%) ⬇️
ydb-24.1 52.81% <19.64%> (-1.24%) ⬇️
ydb-24.2 52.58% <19.64%> (-1.40%) ⬇️
ydb-nightly 70.94% <58.92%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 20, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 20, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Sep 20, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 20, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 20, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

@rekby rekby merged commit 98f75f0 into master Sep 20, 2024
44 checks passed
@rekby rekby deleted the write-message-in-transaction branch September 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants