Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cdc helpers #1472

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Cdc helpers #1472

merged 7 commits into from
Sep 18, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 18, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github.com/ydb-platform/ydb-go-sdk/v3/topic/topicsugar

compatible changes

TopicMessageIterator: added
TopicMessageReader: added
TopicUnmarshalJSONFunc: added
TopicUnmarshalJSONIterator: added
TypedTopicMessage: added
TypedUnmarshalFunc: added
UnmarshalCDCStream: added
YDBCDCItem: added
YDBCDCMessage: added

summary

Base version: v3.80.8-0.20240918151917-efa13b20da2c (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.7.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 61.44578% with 32 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (efa13b2) to head (2cf008a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
topic/topicsugar/iterators.go 52.50% 16 Missing and 3 partials ⚠️
topic/topicsugar/cdc-reader.go 69.76% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
- Coverage   67.97%   67.88%   -0.10%     
==========================================
  Files         350      352       +2     
  Lines       36315    36398      +83     
==========================================
+ Hits        24686    24707      +21     
- Misses      10553    10603      +50     
- Partials     1076     1088      +12     
Flag Coverage Δ
experiment 72.08% <80.95%> (+<0.01%) ⬆️
go-1.21.x 68.00% <0.00%> (-0.22%) ⬇️
go-1.22.x 65.58% <0.00%> (-0.28%) ⬇️
go-1.23.x 67.77% <61.44%> (-0.12%) ⬇️
integration 53.54% <80.95%> (-0.43%) ⬇️
macOS 40.90% <0.00%> (-0.10%) ⬇️
ubuntu 72.32% <80.95%> (-0.08%) ⬇️
unit 41.33% <0.00%> (-0.11%) ⬇️
windows 41.31% <0.00%> (-0.13%) ⬇️
ydb-23.3 47.44% <33.33%> (-0.32%) ⬇️
ydb-24.1 53.49% <80.95%> (-0.32%) ⬇️
ydb-nightly 72.08% <80.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 18, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@rekby rekby merged commit 2dad311 into master Sep 18, 2024
41 checks passed
@rekby rekby deleted the cdc-helpers branch September 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants