Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename experimental method #1466

Merged
merged 1 commit into from
Sep 17, 2024
Merged

rename experimental method #1466

merged 1 commit into from
Sep 17, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 17, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github.com/ydb-platform/ydb-go-sdk/v3/topic/topicreader

incompatible changes

(*Reader).PopBatchTx: removed

compatible changes

(*Reader).PopMessagesBatchTx: added

summary

Base version: v3.80.5 (master)
Cannot suggest a release version.
Incompatible changes were detected.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (054669f) to head (8e67aec).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   67.99%   67.86%   -0.13%     
==========================================
  Files         350      350              
  Lines       36289    36289              
==========================================
- Hits        24674    24629      -45     
- Misses      10541    10573      +32     
- Partials     1074     1087      +13     
Flag Coverage Δ
experiment 72.05% <100.00%> (-0.22%) ⬇️
go-1.21.x 68.10% <0.00%> (-0.25%) ⬇️
go-1.22.x 65.76% <0.00%> (-0.20%) ⬇️
go-1.23.x 67.80% <100.00%> (-0.19%) ⬇️
integration 53.86% <0.00%> (-0.19%) ⬇️
macOS 40.98% <0.00%> (-0.01%) ⬇️
ubuntu 72.27% <100.00%> (-0.15%) ⬇️
unit 41.42% <0.00%> (-0.01%) ⬇️
windows 41.41% <0.00%> (-0.02%) ⬇️
ydb-23.3 47.68% <0.00%> (-0.22%) ⬇️
ydb-24.1 53.66% <0.00%> (-0.32%) ⬇️
ydb-nightly 72.05% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekby rekby merged commit e582517 into master Sep 17, 2024
41 checks passed
@rekby rekby deleted the rename-popbatchtx branch September 17, 2024 09:43
@rekby rekby restored the rename-popbatchtx branch September 17, 2024 09:43
@rekby rekby deleted the rename-popbatchtx branch September 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants