Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fixed panic on usage metrics package from prometheus adapter on `tr… #1461

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

asmyasnikov
Copy link
Member

…ace.Driver.OnNewStream` callback

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added bug Something isn't working metrics labels Sep 16, 2024
@asmyasnikov asmyasnikov self-assigned this Sep 16, 2024
Copy link

summary

Base version: v3.80.3 (master)
Suggested version: v3.80.4

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (900393f) to head (1970ee8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
- Coverage   67.98%   67.79%   -0.20%     
==========================================
  Files         350      350              
  Lines       36284    36288       +4     
==========================================
- Hits        24667    24600      -67     
- Misses      10543    10604      +61     
- Partials     1074     1084      +10     
Flag Coverage Δ
experiment 71.94% <100.00%> (-0.37%) ⬇️
go-1.21.x 68.04% <100.00%> (-0.29%) ⬇️
go-1.22.x 65.71% <100.00%> (-0.20%) ⬇️
go-1.23.x 67.74% <100.00%> (-0.25%) ⬇️
integration 53.80% <100.00%> (-0.24%) ⬇️
macOS 40.97% <0.00%> (-0.02%) ⬇️
ubuntu 72.18% <100.00%> (-0.24%) ⬇️
unit 41.42% <0.00%> (-0.02%) ⬇️
windows 41.41% <0.00%> (-0.03%) ⬇️
ydb-23.3 47.67% <100.00%> (-0.14%) ⬇️
ydb-24.1 53.56% <100.00%> (-0.46%) ⬇️
ydb-nightly 71.94% <100.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

@asmyasnikov asmyasnikov merged commit e3045be into master Sep 16, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the fix-panic branch September 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants