Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added option ydb.WithSessionPoolSessionIdleTimeToLive for restric… #1458

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

asmyasnikov
Copy link
Member

…t idle time of query sessions

  • Fixed bug with leak of query transactions

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added bug Something isn't working query-service pool labels Sep 12, 2024
@asmyasnikov asmyasnikov self-assigned this Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithSessionPoolSessionIdleTimeToLive: added

summary

Base version: v3.80.3-0.20240913152610-200688bf7691 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.2.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 80.15873% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.92%. Comparing base (200688b) to head (d26f929).

Files with missing lines Patch % Lines
internal/query/transaction.go 79.16% 10 Missing ⚠️
internal/query/config/options.go 0.00% 5 Missing ⚠️
options.go 0.00% 4 Missing ⚠️
internal/query/session/status.go 0.00% 2 Missing ⚠️
internal/query/result.go 91.66% 1 Missing ⚠️
internal/query/session.go 75.00% 1 Missing ⚠️
internal/query/session/session.go 93.75% 1 Missing ⚠️
internal/tx/id.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
+ Coverage   67.83%   67.92%   +0.08%     
==========================================
  Files         350      350              
  Lines       36288    36284       -4     
==========================================
+ Hits        24616    24645      +29     
+ Misses      10588    10560      -28     
+ Partials     1084     1079       -5     
Flag Coverage Δ
experiment 72.11% <80.86%> (-0.07%) ⬇️
go-1.21.x 67.95% <78.04%> (-0.11%) ⬇️
go-1.22.x 65.67% <76.98%> (-0.13%) ⬇️
go-1.23.x 67.83% <80.15%> (+0.04%) ⬆️
integration 53.95% <67.82%> (+0.38%) ⬆️
macOS 40.99% <66.95%> (+0.06%) ⬆️
ubuntu 72.34% <80.86%> (+0.08%) ⬆️
unit 41.42% <67.46%> (+0.07%) ⬆️
windows 41.41% <67.46%> (+0.06%) ⬆️
ydb-23.3 47.54% <4.34%> (-0.21%) ⬇️
ydb-24.1 53.83% <67.82%> (+0.27%) ⬆️
ydb-nightly 72.11% <80.86%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 12, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 12, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 12, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 12, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Sep 12, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

…t idle time of query sessions

* Fixed bug with leak of query transactions
@asmyasnikov asmyasnikov merged commit 8cb1931 into master Sep 13, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the fix-tx branch September 13, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pool query-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants