Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use balancer connection with metadata for operation service. #1454

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

neyguvj
Copy link
Collaborator

@neyguvj neyguvj commented Sep 11, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

2024-09-11T23:06:20.337+0300    WARN    middleware/errors.go:201        operation error {"app": "database", "request_id": "80c44aba-c7d5-4a67-89a6-55ca3c14100d", "method": "/Ydb.Operation.V1.OperationService/GetOperation", "operation_status": "TRANSPORT_ERROR", "issues": "", "grpc_status": "InvalidArgument", "error": "rpc error: code = InvalidArgument desc = Database not specified", "trace_id": "cb56e445d3a79eb3f233c8e006976537"}

Issue Number: N/A

What is the new behavior?

User balancer connection with metadata

Other information

Copy link

summary

Base version: v3.80.3-0.20240909181701-1b6f3586630e (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.2.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (1b6f358) to head (2e9b4b2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   67.77%   67.67%   -0.11%     
==========================================
  Files         349      349              
  Lines       36249    36249              
==========================================
- Hits        24569    24530      -39     
- Misses      10592    10622      +30     
- Partials     1088     1097       +9     
Flag Coverage Δ
experiment 71.86% <100.00%> (-0.28%) ⬇️
go-1.21.x 67.93% <100.00%> (-0.24%) ⬇️
go-1.22.x 65.57% <100.00%> (-0.19%) ⬇️
go-1.23.x 67.61% <100.00%> (-0.15%) ⬇️
integration 53.40% <100.00%> (-0.13%) ⬇️
macOS 40.97% <0.00%> (-0.02%) ⬇️
ubuntu 72.08% <100.00%> (-0.12%) ⬇️
unit 41.38% <0.00%> (-0.02%) ⬇️
windows 41.36% <0.00%> (-0.04%) ⬇️
ydb-23.3 47.77% <100.00%> (-0.03%) ⬇️
ydb-24.1 53.20% <100.00%> (-0.30%) ⬇️
ydb-nightly 71.86% <100.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

@asmyasnikov asmyasnikov merged commit a06c3b5 into master Sep 11, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the fix-operation-service-connection branch September 11, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants