Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed log output for SLO #1449

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fixed log output for SLO #1449

merged 2 commits into from
Sep 9, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the SLO label Sep 8, 2024
@asmyasnikov asmyasnikov self-assigned this Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 8, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 8, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 8, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 8, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Sep 9, 2024

summary

Base version: v3.80.2 (master)
Suggested version: v3.80.3

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (ab4aa77) to head (eb4aa2d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   67.75%   65.64%   -2.12%     
==========================================
  Files         349      349              
  Lines       36234    36249      +15     
==========================================
- Hits        24551    23795     -756     
- Misses      10600    11357     +757     
- Partials     1083     1097      +14     
Flag Coverage Δ
experiment ?
go-1.21.x 67.84% <100.00%> (-0.29%) ⬇️
go-1.22.x 65.43% <100.00%> (-0.27%) ⬇️
go-1.23.x 65.54% <100.00%> (-2.20%) ⬇️
integration 53.19% <100.00%> (-0.33%) ⬇️
macOS 40.95% <0.00%> (-0.05%) ⬇️
ubuntu 69.67% <100.00%> (-2.51%) ⬇️
unit 41.39% <0.00%> (-0.02%) ⬇️
windows 41.37% <0.00%> (-0.03%) ⬇️
ydb-23.3 47.41% <0.00%> (-0.53%) ⬇️
ydb-24.1 53.17% <100.00%> (-0.28%) ⬇️
ydb-nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 3be1b9c into master Sep 9, 2024
37 of 41 checks passed
@asmyasnikov asmyasnikov deleted the slo-logs branch September 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants