Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced table client pool to internal/pool #1447

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

summary

Base version: v3.79.3-0.20240906191924-2b869c5a20af (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.79.2.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (2b869c5) to head (f36b8f5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   68.02%   67.65%   -0.37%     
==========================================
  Files         350      349       -1     
  Lines       36669    36225     -444     
==========================================
- Hits        24943    24508     -435     
+ Misses      10629    10626       -3     
+ Partials     1097     1091       -6     
Flag Coverage Δ
experiment 71.74% <100.00%> (-0.39%) ⬇️
go-1.21.x 67.82% <100.00%> (-0.55%) ⬇️
go-1.22.x 65.57% <100.00%> (-0.44%) ⬇️
go-1.23.x 67.56% <100.00%> (-0.43%) ⬇️
integration 53.28% <94.23%> (-0.06%) ⬇️
macOS 40.96% <92.30%> (-0.62%) ⬇️
ubuntu 72.06% <100.00%> (-0.30%) ⬇️
unit 41.37% <93.44%> (-0.67%) ⬇️
windows 41.35% <93.44%> (-0.67%) ⬇️
ydb-23.3 47.66% <94.23%> (+0.76%) ⬆️
ydb-24.1 53.20% <94.23%> (-0.12%) ⬇️
ydb-nightly 71.74% <100.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Sep 6, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

@asmyasnikov asmyasnikov force-pushed the table-pool-replacement branch from 7df2ccf to f36b8f5 Compare September 6, 2024 21:16
@asmyasnikov asmyasnikov merged commit 4830171 into master Sep 6, 2024
41 checks passed
@asmyasnikov asmyasnikov deleted the table-pool-replacement branch September 6, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants