feat: expose DecimalValueFromString
#1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to construct decimals from raw-string representation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
+ Coverage 65.43% 67.12% +1.68%
==========================================
Files 351 351
Lines 36510 36516 +6
==========================================
+ Hits 23892 24510 +618
+ Misses 11537 10902 -635
- Partials 1081 1104 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asmyasnikov
approved these changes
Sep 4, 2024
robot-piglet
pushed a commit
to doublecloud/transfer
that referenced
this pull request
Sep 5, 2024
Remove kikimr/go/ydb dependency, this one is used only for wierd things, so instead of depended on whole legacy driver just make a copy of required interfaces. Copy-paste of decimal parser would be removed once this: <ydb-platform/ydb-go-sdk#1436> is released. 2850b0e5f684b6bc933c812440f687cc9245836d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new constructor for decimals from raw-string representation.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1435
What is the new behavior?
DecimalValueFromStringOther information