Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert decimal to latest working version. #1235

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

neyguvj
Copy link
Collaborator

@neyguvj neyguvj commented May 17, 2024

implementation of decimal formatter was reverted to latest working version (3.66.0)

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A
#1234

What is the new behavior?

Other information

Copy link

summary

Base version: v3.67.1 (master)
Suggested version: v3.67.2

@neyguvj neyguvj requested a review from asmyasnikov May 17, 2024 18:40
Copy link

github-actions bot commented May 17, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented May 17, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented May 17, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented May 17, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented May 17, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@neyguvj neyguvj force-pushed the revert-decimal branch 2 times, most recently from f83606c to 3c75022 Compare May 17, 2024 19:17
@asmyasnikov asmyasnikov merged commit 45d399a into master May 17, 2024
36 checks passed
@asmyasnikov asmyasnikov deleted the revert-decimal branch May 17, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants