Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable funlen linter (part 4) #1224

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

brojeg
Copy link

@brojeg brojeg commented May 13, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 934

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 41.08%. Comparing base (b7a9b51) to head (59b3246).
Report is 106 commits behind head on master.

Files Patch % Lines
internal/credentials/oauth2.go 90.56% 3 Missing and 2 partials ⚠️
internal/credentials/static.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
+ Coverage   40.80%   41.08%   +0.28%     
==========================================
  Files         309      311       +2     
  Lines       32747    33141     +394     
==========================================
+ Hits        13361    13617     +256     
- Misses      18959    19062     +103     
- Partials      427      462      +35     
Flag Coverage Δ
go-1.21.x 43.27% <88.88%> (+0.34%) ⬆️
go-1.22.x 41.06% <88.88%> (+0.27%) ⬆️
macOS 40.54% <86.66%> (+0.24%) ⬆️
ubuntu 40.59% <86.66%> (+0.29%) ⬆️
unit 41.08% <88.88%> (+0.28%) ⬆️
windows 41.05% <88.88%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tool gtrace no need to change because it is an ad-hoc tool

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the breaking action was broken with your PR - because you change a code of gtrace tool

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the review. I've rolled back [writer.go] and added //nolint:funlen where needed.

@asmyasnikov asmyasnikov merged commit 0880f78 into ydb-platform:master May 15, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants