Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* Added table/options.WithQueryService() option for redirect table.Session.Execute call to query.Execute #1202

Closed
wants to merge 3 commits into from
Closed

* Added table/options.WithQueryService() option for redirect table.Session.Execute call to query.Execute #1202

wants to merge 3 commits into from

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Apr 17, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1197

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added enhancement New feature or request query-service labels Apr 17, 2024
@asmyasnikov asmyasnikov self-assigned this Apr 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

github.com/ydb-platform/ydb-go-sdk/v3/balancers

incompatible changes

Endpoint.NodeID: changed from func() uint32 to func() int64

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

WithCallOptions: changed from func(...google.golang.org/grpc.CallOption) github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.CallOptions to func(...google.golang.org/grpc.CallOption) github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.GrpcOpts

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

SessionInfo.NodeID: changed from func() uint32 to func() int64

github.com/ydb-platform/ydb-go-sdk/v3/table/options

incompatible changes

github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.ExecuteOption.ApplyExecuteOption: added

compatible changes

ExecuteDataQueryDesc.WithQueryService: added
WithQueryService: added
withCallOptions.ApplyExecuteOption: added

github.com/ydb-platform/ydb-go-sdk/v3/testutil

incompatible changes

(*balancerStub).HasNode: changed from func(uint32) bool to func(int64) bool

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

EndpointInfo.NodeID: changed from func() uint32 to func() int64
QueryOnTxExecute: changed from func(*Query, *context.Context, call, querySessionInfo, queryTransactionInfo, string) func(error) to func(*Query, *context.Context, call, queryTransactionInfo, string) func(error)
QueryTxExecuteStartInfo.Session: removed
tableSessionInfo.NodeID: changed from func() uint32 to func() int64

summary

Base version: v3.65.4-0.20240421132159-929301659f96 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.65.3.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@asmyasnikov asmyasnikov force-pushed the execute-data-query-over-query branch 3 times, most recently from 078f867 to 715b581 Compare April 18, 2024 11:47
@asmyasnikov asmyasnikov changed the title * Added table/options.UseQueryServiceExecute() option for redirect table.Session.Execute call to query.Execute * Added table/options.WithQueryService() option for redirect table.Session.Execute call to query.Execute Apr 18, 2024
@asmyasnikov asmyasnikov force-pushed the execute-data-query-over-query branch 2 times, most recently from 5e467ce to 42a6c27 Compare April 18, 2024 12:09
@asmyasnikov
* Added table/options.UseQueryServiceExecute() option for redirect …
5802d70 
…`table.Session.Execute` call to `query.Execute`
@asmyasnikov asmyasnikov force-pushed the execute-data-query-over-query branch 3 times, most recently from 28251d3 to ba98296 Compare April 18, 2024 14:19
@asmyasnikov asmyasnikov force-pushed the execute-data-query-over-query branch from ba98296 to f66baf0 Compare April 18, 2024 14:36
@asmyasnikov asmyasnikov force-pushed the execute-data-query-over-query branch from 09c9710 to ba089d9 Compare April 23, 2024 08:47
@asmyasnikov asmyasnikov closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asmyasnikov asmyasnikov

Labels
enhancement New feature or request query-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asmyasnikov