Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added experimental retry/budget package #1184

Merged
merged 21 commits into from
Apr 23, 2024
Merged

added experimental retry/budget package #1184

merged 21 commits into from
Apr 23, 2024

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1183

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the enhancement New feature or request label Apr 5, 2024
@asmyasnikov asmyasnikov self-assigned this Apr 5, 2024
@asmyasnikov asmyasnikov changed the title added quoter implementations added retry.Limiter implementations Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

WithRetryBudget: added

github.com/ydb-platform/ydb-go-sdk/v3/config

compatible changes

WithRetryBudget: added
github.com/ydb-platform/ydb-go-sdk/v3/internal/config.(*Common).RetryBudget: added

github.com/ydb-platform/ydb-go-sdk/v3/query

compatible changes

WithRetryBudget: added

github.com/ydb-platform/ydb-go-sdk/v3/retry

compatible changes

WithBudget: added

github.com/ydb-platform/ydb-go-sdk/v3/retry/budget

compatible changes

package added

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

idempotentOption: changed from struct{} to []github.com/ydb-platform/ydb-go-sdk/v3/retry.Option

compatible changes

WithRetryBudget: added

summary

Base version: v3.65.4-0.20240423084419-d716a3b2218c (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.65.3.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 56.83060% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 41.90%. Comparing base (5d5dff4) to head (4762859).
Report is 28 commits behind head on master.

Files Patch % Lines
internal/xsql/conn.go 0.00% 20 Missing ⚠️
internal/coordination/client.go 0.00% 19 Missing ⚠️
internal/xsql/connector.go 0.00% 8 Missing ⚠️
table/table.go 0.00% 7 Missing ⚠️
internal/scheme/client.go 0.00% 6 Missing ⚠️
options.go 0.00% 6 Missing ⚠️
retry/retry.go 88.23% 4 Missing ⚠️
retry/sql.go 33.33% 4 Missing ⚠️
query/client.go 0.00% 2 Missing ⚠️
retry/quoter.go 95.45% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1184       +/-   ##
===========================================
- Coverage   68.45%   41.90%   -26.55%     
===========================================
  Files         308      255       -53     
  Lines       32416    27522     -4894     
===========================================
- Hits        22190    11534    -10656     
- Misses       9267    15603     +6336     
+ Partials      959      385      -574     
Flag Coverage Δ
?
go-1.21.x 41.90% <56.83%> (-28.61%) ⬇️
go-1.22.x ?
integration ?
macOS ?
ubuntu ?
unit 41.90% <56.83%> (+2.03%) ⬆️
windows 41.90% <56.83%> (+2.04%) ⬆️
ydb-23.3 ?
ydb-24.1 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov force-pushed the retry-quoter branch 10 times, most recently from efe3039 to 5d91a76 Compare April 8, 2024 14:25
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 8, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 8, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 8, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 8, 2024
internal/backoff/delay.go Outdated Show resolved Hide resolved
internal/backoff/delay.go Outdated Show resolved Hide resolved
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 9, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 9, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 9, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 9, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 9, 2024
@ydb-platform ydb-platform deleted a comment from github-actions bot Apr 9, 2024
@asmyasnikov asmyasnikov changed the title added retry.Limiter implementations added retry.Budget implementations Apr 22, 2024
@asmyasnikov asmyasnikov changed the title added retry.Budget implementations added experimental retry/budget package Apr 22, 2024
retry/budget/budget.go Show resolved Hide resolved
retry/budget/budget.go Outdated Show resolved Hide resolved
retry/budget/budget.go Show resolved Hide resolved
@asmyasnikov asmyasnikov merged commit b50dba0 into master Apr 23, 2024
36 checks passed
@asmyasnikov asmyasnikov deleted the retry-quoter branch April 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants