Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable forcetypeassert linter #1138

Closed
wants to merge 232 commits into from
Closed

enable forcetypeassert linter #1138

wants to merge 232 commits into from

Conversation

korovindenis
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #933

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 38.12950% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 67.82%. Comparing base (78287b7) to head (49be796).
Report is 2 commits behind head on master.

Files Patch % Lines
internal/value/nullable.go 50.00% 11 Missing and 11 partials ⚠️
internal/table/client.go 33.33% 5 Missing and 5 partials ⚠️
internal/cmd/gtrace/writer.go 0.00% 9 Missing ⚠️
internal/types/types.go 0.00% 8 Missing ⚠️
log/field.go 50.00% 4 Missing and 4 partials ⚠️
internal/value/value.go 50.00% 3 Missing and 3 partials ⚠️
internal/table/transaction.go 0.00% 4 Missing ⚠️
internal/xcontext/local_dc.go 0.00% 4 Missing ⚠️
internal/table/scanner/scan_raw.go 0.00% 3 Missing ⚠️
internal/allocator/allocator.go 50.00% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   67.70%   67.82%   +0.11%     
==========================================
  Files         297      297              
  Lines       29909    30006      +97     
==========================================
+ Hits        20250    20351     +101     
+ Misses       8738     8713      -25     
- Partials      921      942      +21     
Flag Coverage Δ
53.39% <20.00%> (+0.34%) ⬆️
go-1.21.x 69.23% <40.76%> (-0.15%) ⬇️
go-1.22.x 67.54% <38.12%> (-0.16%) ⬇️
integration 53.39% <20.00%> (+0.34%) ⬆️
macOS 39.57% <32.37%> (-0.07%) ⬇️
ubuntu 39.57% <32.37%> (-0.06%) ⬇️
unit 39.61% <32.37%> (-0.08%) ⬇️
windows 39.58% <32.37%> (-0.05%) ⬇️
ydb-23.3 48.24% <20.00%> (-0.21%) ⬇️
ydb-24.1 53.29% <20.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asmyasnikov and others added 29 commits April 9, 2024 17:14
Fix comment for `retry.Retry` function
updated actions checkout, setup-go, golangci-lint-action, codeql-actions and upload-artifact
* Supported `table.Session.RenameTables` method
moved internal/conn.lastUsage into internal/xsync package
Implement OAuth 2.0 Token Exchange credentials provider in Go SDK
@korovindenis korovindenis closed this by deleting the head repository Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.