Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* The minimum version of Go in ydb-go-sdk has been raised to go1.20 #1004

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the dependencies Pull requests that update a dependency file label Jan 17, 2024
@asmyasnikov asmyasnikov self-assigned this Jan 17, 2024
Copy link

summary

Base version: v3.54.4-0.20240115135953-adb5de88c27b (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.3.

@asmyasnikov asmyasnikov force-pushed the go1.20 branch 2 times, most recently from 9416912 to 5ec0b4c Compare January 17, 2024 09:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (adb5de8) 67.64% compared to head (29324ae) 67.39%.

Files Patch % Lines
internal/allocator/allocator.go 73.27% 111 Missing and 17 partials ⚠️
sugar/params.go 25.92% 18 Missing and 2 partials ⚠️
internal/xsql/unwrap.go 35.00% 13 Missing ⚠️
internal/xstring/convert.go 18.18% 6 Missing and 3 partials ⚠️
internal/xsql/badconn/badconn.go 72.22% 5 Missing ⚠️
retry/errors.go 33.33% 1 Missing and 1 partial ⚠️
internal/xbytes/clone.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
- Coverage   67.64%   67.39%   -0.26%     
==========================================
  Files         261      252       -9     
  Lines       24686    24509     -177     
==========================================
- Hits        16700    16518     -182     
+ Misses       7127     7122       -5     
- Partials      859      869      +10     
Flag Coverage Δ
53.90% <66.84%> (-0.38%) ⬇️
go-1.17.x ?
go-1.20.x 67.37% <68.27%> (-0.15%) ⬇️
go-1.21.x 67.37% <68.27%> (-0.04%) ⬇️
integration 53.90% <66.84%> (-0.38%) ⬇️
macOS 38.82% <25.92%> (+<0.01%) ⬆️
ubuntu 38.81% <25.92%> (-0.01%) ⬇️
unit 38.90% <25.92%> (-0.01%) ⬇️
windows 38.88% <25.92%> (-0.01%) ⬇️
ydb-22.5 53.59% <65.95%> (-0.26%) ⬇️
ydb-23.1 53.67% <66.84%> (-0.08%) ⬇️
ydb-23.2 53.71% <66.84%> (-0.02%) ⬇️
ydb-23.3 53.85% <66.84%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@asmyasnikov asmyasnikov merged commit 669aaf2 into master Jan 18, 2024
42 checks passed
@asmyasnikov asmyasnikov deleted the go1.20 branch January 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants