Skip to content

Commit

Permalink
fix integration tests for skip message metadata for old versions
Browse files Browse the repository at this point in the history
  • Loading branch information
rekby committed Dec 15, 2023
1 parent 4685172 commit 734edc1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions internal/topic/topicwriterinternal/writer_reconnector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ func TestWriterImpl_Write(t *testing.T) {
mess := expectedMap[k]
_, err = mess.GetEncodedBytes(rawtopiccommon.CodecRaw)
require.NoError(t, err)
mess.metadataCached = true
expectedMap[k] = mess

Check failure on line 111 in internal/topic/topicwriterinternal/writer_reconnector_test.go

View workflow job for this annotation

GitHub Actions / golangci-lint

unnecessary trailing newline (whitespace)
}

require.Equal(t, expectedMap, w.queue.messagesByOrder)
Expand Down
8 changes: 8 additions & 0 deletions tests/integration/topic_read_writer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"encoding/binary"
"errors"
"io"
"os"
"runtime/pprof"
"strconv"
"strings"
Expand All @@ -22,6 +23,7 @@ import (
"github.com/ydb-platform/ydb-go-sdk/v3"
"github.com/ydb-platform/ydb-go-sdk/v3/config"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/empty"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/version"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xatomic"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xtest"
"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions"
Expand Down Expand Up @@ -123,6 +125,9 @@ func TestMessageMetadata(t *testing.T) {
e.Require.Nil(mess.Metadata)
})
t.Run("Meta1", func(t *testing.T) {
if version.Lt(os.Getenv("YDB_VERSION"), "24.0") {
t.Skip()
}
e := newScope(t)
meta := map[string][]byte{
"key": []byte("val"),
Expand All @@ -137,6 +142,9 @@ func TestMessageMetadata(t *testing.T) {
e.Require.Equal(meta, mess.Metadata)
})
t.Run("Meta2", func(t *testing.T) {
if version.Lt(os.Getenv("YDB_VERSION"), "24.0") {
t.Skip()
}
e := newScope(t)
meta := map[string][]byte{
"key1": []byte("val1"),
Expand Down

0 comments on commit 734edc1

Please sign in to comment.