Skip to content

Commit

Permalink
fix tests + added integration tests for YDB 24.2
Browse files Browse the repository at this point in the history
  • Loading branch information
asmyasnikov committed Sep 18, 2024
1 parent 9cd2f73 commit 613f294
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
fail-fast: false
matrix:
go-version: [1.21.x, 1.22.x, 1.23.x]
ydb-version: [23.3, 24.1]
ydb-version: [23.3, 24.1, 24.2]
os: [ubuntu]
services:
ydb:
Expand Down
12 changes: 2 additions & 10 deletions tests/integration/query_tx_execute_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,7 @@ func TestQueryTxExecute(t *testing.T) {
}
return nil
}, query.WithIdempotent(), query.WithTxSettings(query.TxSettings(query.WithOnlineReadOnly())))
if version.Lt(os.Getenv("YDB_VERSION"), "24.3") {
require.NoError(t, err)
} else {
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
}
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
})
t.Run("StaleReadOnly", func(t *testing.T) {
err := scope.DriverWithLogs().Query().DoTx(scope.Ctx, func(ctx context.Context, tx query.TxActor) (err error) {
Expand All @@ -227,11 +223,7 @@ func TestQueryTxExecute(t *testing.T) {
}
return nil
}, query.WithIdempotent(), query.WithTxSettings(query.TxSettings(query.WithStaleReadOnly())))
if version.Lt(os.Getenv("YDB_VERSION"), "24.3") {
require.NoError(t, err)
} else {
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
}
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
})
t.Run("ErrOptionNotForTxExecute", func(t *testing.T) {
err := scope.DriverWithLogs().Query().DoTx(scope.Ctx, func(ctx context.Context, tx query.TxActor) (err error) {
Expand Down

0 comments on commit 613f294

Please sign in to comment.