add explicit initialization of fields of structures in internal/xerrors

ydb-platform · Apr 15, 2024 · 4140b14 · 4140b14
1 parent 14511ab
commit 4140b14
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 10 deletions.
diff --git a/internal/xerrors/issues.go b/internal/xerrors/issues.go
@@ -59,6 +59,7 @@ func (ii issues) String() string {
 func NewWithIssues(text string, issues ...error) error {
 	err := &withIssuesError{
 		reason: text,
+		issues: nil,
 	}
 	for i := range issues {
 		if issues[i] != nil {

diff --git a/internal/xerrors/operation.go b/internal/xerrors/operation.go
@@ -84,8 +84,10 @@ func (e *operationOption) applyToOperationError(oe *operationError) {
 // FromOperation must use as `Operation(FromOperation(operation.Status))`
 func FromOperation(operation operation.Status) *operationOption {
 	return &operationOption{
-		code:   operation.GetStatus(),
-		issues: operation.GetIssues(),
+		code:    operation.GetStatus(),
+		issues:  operation.GetIssues(),
+		address: "",
+		traceID: "",
 	}
 }
 
@@ -95,7 +97,10 @@ type oeOpt interface {
 
 func Operation(opts ...oeOpt) error {
 	oe := &operationError{
-		code: Ydb.StatusIds_STATUS_CODE_UNSPECIFIED,
+		code:    Ydb.StatusIds_STATUS_CODE_UNSPECIFIED,
+		issues:  nil,
+		address: "",
+		traceID: "",
 	}
 	for _, opt := range opts {
 		if opt != nil {

diff --git a/internal/xerrors/retryable.go b/internal/xerrors/retryable.go
@@ -68,6 +68,7 @@ func Retryable(err error, opts ...RetryableErrorOption) error {
 		re = &retryableError{
 			err:                err,
 			name:               "CUSTOM",
+			backoffType:        backoff.TypeNoBackoff,
 			code:               -1,
 			isRetryObjectValid: true,
 		}

diff --git a/internal/xerrors/stacktrace.go b/internal/xerrors/stacktrace.go
@@ -23,7 +23,7 @@ func WithStackTrace(err error, opts ...withStackTraceOption) error {
 	if err == nil {
 		return nil
 	}
-	options := withStackTraceOptions{}
+	options := withStackTraceOptions{skipDepth: 0}
 	for _, opt := range opts {
 		if opt != nil {
 			opt(&options)

diff --git a/internal/xerrors/transport.go b/internal/xerrors/transport.go
@@ -145,13 +145,17 @@ func Transport(err error, opts ...teOpt) error {
 	}
 	if s, ok := grpcStatus.FromError(err); ok {
 		te = &transportError{
-			status: s,
-			err:    err,
+			status:  s,
+			err:     err,
+			address: "",
+			traceID: "",
 		}
 	} else {
 		te = &transportError{
-			status: grpcStatus.New(grpcCodes.Unknown, stack.Record(1)),
-			err:    err,
+			status:  grpcStatus.New(grpcCodes.Unknown, stack.Record(1)),
+			err:     err,
+			address: "",
+			traceID: "",
 		}
 	}
 	for _, opt := range opts {
@@ -194,8 +198,10 @@ func TransportError(err error) Error {
 	}
 	if s, ok := grpcStatus.FromError(err); ok {
 		return &transportError{
-			status: s,
-			err:    err,
+			status:  s,
+			err:     err,
+			address: "",
+			traceID: "",
 		}
 	}