Skip to content

Commit

Permalink
Merge pull request #1440 from ydb-platform/hide-eof-in-log
Browse files Browse the repository at this point in the history
Hide EOF error in recvMsg logs
  • Loading branch information
neyguvj authored Sep 4, 2024
2 parents 279aae7 + a94bb79 commit 0f5a484
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* EOF error in RecvMsg is no longer logged

## v3.78.0
* Changed result type of method `query.Executor.QueryResultSet` from `query.ResultSet` to `query.ClosableResultSet`
* Added `table/types.DecimalValueFromString` decimal type constructor
Expand Down
3 changes: 2 additions & 1 deletion log/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"time"

"github.com/ydb-platform/ydb-go-sdk/v3/internal/secret"
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
"github.com/ydb-platform/ydb-go-sdk/v3/trace"
)

Expand Down Expand Up @@ -302,7 +303,7 @@ func internalDriver(l Logger, d trace.Detailer) trace.Driver {
start := time.Now()

return func(info trace.DriverConnStreamRecvMsgDoneInfo) {
if info.Error == nil {
if xerrors.HideEOF(info.Error) == nil {
l.Log(ctx, "done",
latencyField(start),
)
Expand Down

0 comments on commit 0f5a484

Please sign in to comment.