Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-463: start nbd-endpoint with any available nbd-device #770

Merged
merged 1 commit into from
Mar 19, 2024
Merged

issue-463: start nbd-endpoint with any available nbd-device #770

merged 1 commit into from
Mar 19, 2024

Conversation

sanek325
Copy link
Collaborator

Add flag UseFreeNbdDevice to StartEndpoint request.
NBS gets first available nbd device and connects it to started nbd endpoint.

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 74a8f25.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5050 5046 0 0 2 2

sharpeye
sharpeye previously approved these changes Mar 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit eea40a0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5049 5045 0 0 2 2

@sanek325 sanek325 force-pushed the issue-463 branch 3 times, most recently from 8c9d568 to f915ee3 Compare March 19, 2024 15:16
budevg
budevg previously approved these changes Mar 19, 2024
View reviewed changes
yegorskii
yegorskii previously approved these changes Mar 19, 2024
View reviewed changes
@sanek325 sanek325 dismissed stale reviews from yegorskii and budevg via fd74c64 March 19, 2024 15:41
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit fd74c64.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5048 5045 0 0 1 2

@sanek325 sanek325 merged commit 4144ca7 into main Mar 19, 2024
7 checks passed
@sanek325 sanek325 deleted the issue-463 branch March 19, 2024 17:05
sanek325 added a commit that referenced this pull request Mar 19, 2024
@sanek325
issue-463: start nbd-endpoint with any connected nbd-device (#770)
a49b29b
sanek325 added a commit that referenced this pull request Mar 20, 2024
@sanek325
Merge to stable-23-3 (#784)
61f639f 
* issues-463: start nbd-endpoint with a connected nbd-device (#658)

* tweak endpoint_manager (#694)

* move EndpointStorage usage from endpoint_service to endpoint_manager (#704)

* issue-463: start nbd-endpoint with any connected nbd-device (#770)

* fix cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharpeye sharpeye sharpeye left review comments

@yegorskii yegorskii yegorskii approved these changes

@budevg budevg budevg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanek325 @budevg @sharpeye @yegorskii