NBS-4773 [blockstore] Fix checkpoint without data creation #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbasic
requested changes
Mar 14, 2024
drbasic
approved these changes
Mar 14, 2024
leftmain
added
large-tests
sanek325
approved these changes
Mar 18, 2024
leftmain
deleted the
users/leftmain/fix-checkpoint-without-data-creation
branch
leftmain
added a commit
that referenced
this pull request
Mar 19, 2024
* write test ShouldNotReadFromCheckpointWithoutData * create normal checkpoint and delete data * pass CheckpointType when create checkpoint for network disk * fix clang-format
leftmain
added a commit
that referenced
this pull request
Mar 19, 2024
* NBS-4773 [blockstore] Fix checkpoint without data creation (#738) * write test ShouldNotReadFromCheckpointWithoutData * create normal checkpoint and delete data * pass CheckpointType when create checkpoint for network disk * fix clang-format * use NProto::ECheckpointType for checkpoint creation (#773)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix makes sure the withoutdata parameter is properly sent to the partition tablet. It's important to wait DM release (with commit) to merge this fix.