Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blockstore] support DescribeBlocks method for disks with several partitions #662

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[Blockstore] support DescribeBlocks method for disks with several partitions #662

merged 3 commits into from
Mar 20, 2024

Conversation

BarkovBG
Copy link
Collaborator

@BarkovBG BarkovBG commented Mar 6, 2024 •
edited
Loading

issue #356

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit e67e78a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4784 4708 0 4 0 72

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit d92e35f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4785 4712 0 1 0 72

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit cb42ef9.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4786 4710 0 0 2 74

@BarkovBG BarkovBG changed the title draft [Blockstore] support DescribeBlocks method for disks with several partitions Mar 7, 2024
@BarkovBG BarkovBG changed the title [Blockstore] support DescribeBlocks method for disks with several partitions issue #356: [Blockstore] support DescribeBlocks method for disks with several partitions Mar 7, 2024
@BarkovBG BarkovBG marked this pull request as ready for review March 7, 2024 18:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 10edbce.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4784 4712 0 0 0 72

@BarkovBG BarkovBG marked this pull request as draft March 7, 2024 22:15
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5625b0f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4785 4713 0 0 0 72

@github-actions GitHub Actions
Copy link
Contributor

Treating build_and_test_act.yaml as a Workflow definition
Treating build_and_test_act_cmake.yaml as a Workflow definition
Treating nightly.yaml as a Workflow definition
Treating build_and_test_on_demand_cmake.yaml as a Workflow definition
Treating pr.yaml as a Workflow definition
Treating pr-github-actions.yaml as a Workflow definition
Treating build_and_test_cmake.yaml as a Workflow definition
Treating build_and_test_ya.yaml as a Workflow definition
Treating pr-cmake.yaml as a Workflow definition
Treating github_actions_scripts.yaml as a Workflow definition
Treating nightly-index-rebuild.yaml as a Workflow definition
Treating build_and_test_on_demand.yaml as a Workflow definition

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x64-relwithdebinfo: some tests FAILED for commit e4ad90e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5015 4903 0 62 5 45

@BarkovBG BarkovBG force-pushed the users/barkovbg/multibase branch 3 times, most recently from 5aedb3e to 216bf97 Compare March 13, 2024 17:11
@BarkovBG BarkovBG marked this pull request as ready for review March 13, 2024 17:14
@BarkovBG BarkovBG changed the title issue #356: [Blockstore] support DescribeBlocks method for disks with several partitions [Blockstore] support DescribeBlocks method for disks with several partitions Mar 14, 2024
@BarkovBG BarkovBG force-pushed the users/barkovbg/multibase branch 3 times, most recently from 07df490 to 6721f0e Compare March 14, 2024 15:24
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 6721f0e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4786 4713 0 1 0 72

@BarkovBG BarkovBG force-pushed the users/barkovbg/multibase branch from 6721f0e to 81c34f9 Compare March 18, 2024 11:49
@BarkovBG BarkovBG marked this pull request as draft March 18, 2024 12:33
@BarkovBG BarkovBG force-pushed the users/barkovbg/multibase branch from 81c34f9 to 6501fa7 Compare March 18, 2024 12:37
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6501fa7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4787 4715 0 0 0 72

@BarkovBG BarkovBG force-pushed the users/barkovbg/multibase branch from e156194 to ed3e18c Compare March 18, 2024 15:28
@BarkovBG BarkovBG marked this pull request as ready for review March 18, 2024 16:26
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ed3e18c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5035 5035 0 0 0 0

@BarkovBG BarkovBG merged commit ffc1fdc into main Mar 20, 2024
4 of 5 checks passed
@BarkovBG BarkovBG deleted the users/barkovbg/multibase branch March 20, 2024 12:13
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3a41c1a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5035 5034 0 1 0 0

BarkovBG added a commit that referenced this pull request Mar 27, 2024
@BarkovBG
[Blockstore] support DescribeBlocks method for disks with several par…
c234c82 
…titions (#662)
BarkovBG added a commit that referenced this pull request Mar 27, 2024
@BarkovBG
[Blockstore] support DescribeBlocks method for disks with several par…
c043313 
…titions (#662)
BarkovBG added a commit that referenced this pull request Mar 27, 2024
@BarkovBG @qkrorlqr
cherry-pick 23-3 support multipartition base disks for proxy overlay …
c405262 
…disks (#830)

* [Blockstore] support DescribeBlocks method for disks with several partitions  (#662)

* [Blockstore] do not calculate logical used blocks metric for proxy overlay disks (#786)

* do not calculate logical used blocks metric for proxy overlay disks

* resolve issues

* add comment

* fix comment

* fix comment

* fix comment

* fix comment

* issue-356: cleanup after PR 786 (#798)

---------

Co-authored-by: Andrei Strelkovskii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvartMetal SvartMetal SvartMetal left review comments

@yegorskii yegorskii yegorskii approved these changes

@qkrorlqr qkrorlqr qkrorlqr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BarkovBG @qkrorlqr @SvartMetal @yegorskii