Add devices to pending cleanup only when necessary #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komarevtsev-d
added
large-tests
komarevtsev-d
commented
Jan 13, 2025
sharpeye
reviewed
Jan 14, 2025
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp
Outdated
Show resolved
Hide resolved
drbasic
previously approved these changes
Jan 15, 2025
komarevtsev-d
force-pushed
the
users/komarevtsev-d/issue-3/4
branch
from
32af0f7 to
f5e79f0
Compare
drbasic
approved these changes
Jan 15, 2025
sharpeye
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В процессе написания #3, появилась надобность правильнее учитывать pending cleanup. Здесь я взял уже правильно написаный кусок из
TDiskRegistryState::DeallocateDiskи вынес его в общий метод.