NBS-4827 fix review issues #1

ydb-platform · Mar 11, 2024 · 3b1ded0 · 3b1ded0
1 parent 8d2e470
commit 3b1ded0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/cloud/blockstore/libs/storage/volume/actors/shadow_disk_actor.cpp b/cloud/blockstore/libs/storage/volume/actors/shadow_disk_actor.cpp
@@ -529,18 +529,18 @@ bool TShadowDiskActor::OnMessage(
                 *reinterpret_cast<TEvService::TEvWriteBlocksRequest::TPtr*>(
                     &ev),
                 ctx);
-        } break;
+        }
         case TEvService::TEvWriteBlocksLocalRequest::EventType: {
             return HandleWriteZeroBlocks<TEvService::TWriteBlocksLocalMethod>(
                 *reinterpret_cast<
                     TEvService::TEvWriteBlocksLocalRequest::TPtr*>(&ev),
                 ctx);
-        } break;
+        }
         case TEvService::TEvZeroBlocksRequest::EventType: {
             return HandleWriteZeroBlocks<TEvService::TZeroBlocksMethod>(
                 *reinterpret_cast<TEvService::TEvZeroBlocksRequest::TPtr*>(&ev),
                 ctx);
-        } break;
+        }
 
         default:
             // Message processing by the base class is required.

diff --git a/cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp b/cloud/blockstore/libs/storage/volume/volume_actor_checkpoint.cpp
@@ -1332,7 +1332,7 @@ void TVolumeActor::CompleteUpdateCheckpointRequest(
         args.Completed ? "completed" : "rejected",
         args.ShadowDiskId.Quote().c_str());
 
-    const bool needDestroyShadowActor =
+    const bool needToDestroyShadowActor =
         (request.ReqType == ECheckpointRequestType::Delete ||
          request.ReqType == ECheckpointRequestType::DeleteData) &&
          State->GetCheckpointStore().HasShadowActor(request.CheckpointId);
@@ -1344,12 +1344,12 @@ void TVolumeActor::CompleteUpdateCheckpointRequest(
         args.ShadowDiskState);
     CheckpointRequests.erase(request.RequestId);
 
-    const bool needCreateShadowActor =
+    const bool needToCreateShadowActor =
         request.ReqType == ECheckpointRequestType::Create &&
         !request.ShadowDiskId.Empty() &&
         !State->GetCheckpointStore().HasShadowActor(request.CheckpointId);
 
-    if (needDestroyShadowActor || needCreateShadowActor) {
+    if (needToDestroyShadowActor || needToCreateShadowActor) {
         RestartDiskRegistryBasedPartition(ctx);
     }