Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Downgrade JDT to version 1.40.0 #1774

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Dec 14, 2024

Newer versions (1.41+) have a bug where a shutdown request that is sent immediatey after the server claims to be ready results in a NullPointerException.


This change is Reviewable

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@puremourning puremourning added the Ship It! Manual override to merge a PR by maintainer label Dec 14, 2024
Newer versions (1.41+) have a bug where a shutdown request that is sent
immediatey after the server claims to be ready results in a
NullPointerException.
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (dab4ad4) to head (23a7e89).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
+ Coverage   95.50%   95.86%   +0.36%     
==========================================
  Files          84       84              
  Lines        8469     8469              
  Branches      163      163              
==========================================
+ Hits         8088     8119      +31     
+ Misses        331      300      -31     
  Partials       50       50              

Copy link
Contributor

mergify bot commented Dec 14, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit a51329a into ycm-core:master Dec 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants